Repository navigation
Name the scattering-matrix backend for what it is, not PRISM - #35
Merged
Merged
Conversation
"bloch_prism" / BlochPrismBackend solves the Bloch-wave model by Sturkey's scattering matrix (a matrix exponential stepped through the depth slices), equal to the eigendecomposition; it is not Ophus's PRISM, which interpolates a STEM scattering matrix in Fourier space. It is now backend="bloch_smatrix", BlochScatteringMatrixBackend in de_ebsd.diffraction.smatrix, with its references (Sturkey 1962; Wang & De Graef 2016; Singh & De Graef 2018; Winkelmann et al. 2007; Callahan & De Graef 2013; and Ophus 2017 for what it is not) in the module and the architecture notes. The old names still work, with a DeprecationWarning: "bloch_prism", de_ebsd.BlochPrismBackend, de_ebsd.diffraction.BlochPrismBackend and de_ebsd.diffraction.prism. Results are unchanged. Claude-Session: https://claude.ai/code/session_01DzXsKAUJSM4XYpqqzrcuV5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bloch_prism/BlochPrismBackendsolves the same Bloch-wave model asblochthrough the scattering matrix: the wave at depth n·dz is Σⁿ applied to the incident beam, with Σ = exp(i·phase·A). That's Sturkey's (1962) formulation, mathematically equal to the eigendecomposition;test_scattering_matrix.pychecks it to 1e-9. It is not Ophus's PRISM (2017), which gets its speed from Fourier interpolation of a STEM scattering matrix. Nothing here is interpolated.Changes
backend="bloch_smatrix"(still the default),BlochScatteringMatrixBackend, and the modulede_ebsd.diffraction.smatrix.The architecture notes say the same.
DeprecationWarning:"bloch_prism",de_ebsd.BlochPrismBackend,de_ebsd.diffraction.BlochPrismBackendandde_ebsd.diffraction.prism. A test pins each one.+scattering-matrix.deprecation.rst.Results are unchanged. Ran
ruff check,ruff format --checkand the full suite: 670 passed, 16 skipped.https://claude.ai/code/session_01DzXsKAUJSM4XYpqqzrcuV5