Repository navigation
Fix three ways an install can silently run wrong or lose its settings - #38
Open
CSSFrancis wants to merge 2 commits into
Open
CSSFrancis wants to merge 2 commits into
CSSFrancis wants to merge 2 commits into
Conversation
CSSFrancis
added a commit
that referenced
this pull request
Nov 7, 2026
- The environment stamp includes a digest of the staged app and member wheels, and they are installed with --reinstall, so a rebuild that keeps uv.lock and the version no longer keeps running the previous build's Python (#25). Existing installs re-sync once after upgrading. - settings.json is written atomically (temporary file, then rename), an unreadable file is moved aside to settings.json.bad-<time> instead of being overwritten with defaults, and save failures log as warnings (#24). - PYTHONPATH and PYTHONHOME are removed from the environment of the backend and of uv, so another Python's settings cannot shadow the app's dependencies or stop the interpreter starting (#27).
CSSFrancis
force-pushed
the
fix/silent-env-failures
branch
from
November 16, 2026 17:45
338962e to
30500e5
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#25 — a same-version rebuild ran the old Python. The env stamp was only
uv.lockplus extras, so a rebuild that left both alone put new wheels on disk and never installed them. The stamp now adds a sha256 over every staged wheel's name and bytes (envStamp,stagedWheelsDigest). That alone was not enough: uv skips a wheel whose name and version are already installed, soinstallAppWheelnow passes--reinstall(with--no-depsit touches only that wheel). Existing installs see a new stamp and re-sync once after upgrading de-shell.#24 — settings.json.
settings.json.bad-<time>and logged as a warning, instead of being overwritten with defaults on the next save.#27 — PYTHONPATH and PYTHONHOME. Removed (case-insensitively) from the environment the backend starts with, and from uv's. Removing them, rather than running
python -E, keepsPYTHONUNBUFFEREDand any variable a user sets on purpose, and covers worker processes, which inherit the environment. This applies in development too. Not run in a packaged app with the variables set; the filter is unit-tested.Typecheck, 186 unit tests and 133 pytest tests pass locally.
Closes #25, closes #24, closes #27.