Repository navigation
Replace three operator texts that showed internals - #40
Merged
Merged
Conversation
- First-run setup leaves out the PyTorch step for an app with no torch in
its lock: main sends torch: false on the start message, read from the
bundled uv.lock as setupEnv already does.
- A failed setup says "Details are in the setup log below. Press Retry.
If this PC has no internet, press Install from a folder…" instead of a
tool's exit code; the raw error becomes the log's last line.
- A failed message names the action ("find_vectors failed — details are
in the log.") instead of showing the exception text, and the log record
names it too.
Part of #30. "Backend stopped" follows once #39, which rewrites how
backend_exited is sent, is merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three of the four texts in #30, as proposed there:
runEnvSetupreads the bundleduv.lock(the samereadLockedTorchVersionthatsetupEnvuses), and the machine sendstorch: falseon thestartmessage. The reducer keeps it onEnvSetupState, andphasePills(phase, torch = true)leaves the pill out. An older main that doesn't send it keeps today's pills, so SpyDE is unchanged.uv sync exited with code 1, becomes the last line of the log tail, so it stays on screen.log.exceptionnames the action, so the traceback says what failed.Not in this PR: "Backend stopped". Its fix carries the app name on
backend_exited, and #39 rewrites exactly the code that sends that message. I'll add it once #39 is merged rather than make the two conflict.Not rendered in a packaged app; the reducer, pills, machine message and failure text are unit-tested. Typecheck, 183 unit tests and 131 pytest tests pass locally.
Part of #30.