Skip to content

Replace three operator texts that showed internals - #40

Merged
CSSFrancis merged 2 commits into
mainfrom
fix/operator-texts
Nov 8, 2026
Merged

CSSFrancis merged 2 commits into
mainfrom
fix/operator-texts

Conversation

@CSSFrancis

Copy link
Copy Markdown
Member

Three of the four texts in #30, as proposed there:

  1. No PyTorch step for apps without torch. runEnvSetup reads the bundled uv.lock (the same readLockedTorchVersion that setupEnv uses), and the machine sends torch: false on the start message. The reducer keeps it on EnvSetupState, and phasePills(phase, torch = true) leaves the pill out. An older main that doesn't send it keeps today's pills, so SpyDE is unchanged.
  2. No tool exit code as the setup error. The red line now reads "Details are in the setup log below. Press Retry. If this PC has no internet, press Install from a folder…". The raw error, such as uv sync exited with code 1, becomes the last line of the log tail, so it stays on screen.
  3. No raw exception on the status bar. It now shows "find_vectors failed — details are in the log." (the message type for a non-action). log.exception names the action, so the traceback says what failed.

Not in this PR: "Backend stopped". Its fix carries the app name on backend_exited, and #39 rewrites exactly the code that sends that message. I'll add it once #39 is merged rather than make the two conflict.

Not rendered in a packaged app; the reducer, pills, machine message and failure text are unit-tested. Typecheck, 183 unit tests and 131 pytest tests pass locally.

Part of #30.

- First-run setup leaves out the PyTorch step for an app with no torch in
  its lock: main sends torch: false on the start message, read from the
  bundled uv.lock as setupEnv already does.
- A failed setup says "Details are in the setup log below. Press Retry.
  If this PC has no internet, press Install from a folder…" instead of a
  tool's exit code; the raw error becomes the log's last line.
- A failed message names the action ("find_vectors failed — details are
  in the log.") instead of showing the exception text, and the log record
  names it too.

Part of #30. "Backend stopped" follows once #39, which rewrites how
backend_exited is sent, is merged.
@CSSFrancis
CSSFrancis merged commit 5061429 into main Nov 8, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant