Repository navigation
Add the screen recorder, moved from SpyDE - #42
Merged
Merged
Conversation
An app records its own window to a video file: registerScreenRecorder(win) in main answers the display-media request with the window itself (no picker, nothing outside the app), the preload bridge's recorder names the file and appends chunks, and <ScreenRecorder> with toggleScreenRecording() drives it and shows the REC pill. A recording that never got a byte leaves no empty file. Claude-Session: https://claude.ai/code/session_01DzXsKAUJSM4XYpqqzrcuV5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SpyDE's Help → Record Screen, moved into the shell so every app gets it (Autopilot is the first to wire it).
registerScreenRecorder(win)answersgetDisplayMediawith the window's own frame: no source picker, nothing outside the app in the file, no macOS Screen Recording prompt. The IPC is inscreenRecorderCore.tswith Electron and the disk injected, so it runs undernode --test.recorder.start(format)/chunk(bytes)/stop()on<appId>:record-*. The path stays in main, so chunks only ever land in the file the user named.<ScreenRecorder recorder={window.<app>.recorder} style?>plustoggleScreenRecording(), to be called from a real click (Chromium needs user activation).stylemoves the pill for an app whose title bar center is taken.Differences from SpyDE's copy:
SpyDE's own copy can be dropped once this is released (a follow-up SpyDE PR).
Checks run:
npm run typecheck,npm run test:unit(201 pass, 1 skipped; 12 new recorder tests). Autopilot's e2e (screen-recorder.spec.ts, Autopilot's companion PR) records 4 s through this branch and checks the file on disk.https://claude.ai/code/session_01DzXsKAUJSM4XYpqqzrcuV5