Repository navigation
Warn from server deprecation headers - #54
Merged
Merged
Conversation
Hardcoded warnings needed an SDK release for every deprecation and fired on each call, even without a request. The server now sends Deprecation on retired routes, so the transport warns once per endpoint and new deprecations reach existing SDK versions.
|
Automatic reviews are disabled for this repository. Configure in Code Review Settings. |
The API dropped steps and tightened validation, so the stepwise client would be rejected with 422 before it ever shipped.
contacts.count stays supported, so it no longer warns. Deprecation warnings now come from the server's headers on every call and are visible by default, so callers cannot miss a sunset.
The contract check against the platform's development spec failed on the contacts run models, which still carried flat rows and internal step fields the API stopped sending and lacked the progress, totals, filters, email state and stop reason it now returns, and on discover and count, which did not know valid_mx. Regenerating the request models from that spec also picks up the larger server default for max_records and clears suggested_email from PENDING_PROPERTIES now that the spec carries it. ExtractResult.language stays for #55.
The API removes the field from /extract, so the contract check would flag it once that release is live. Merge after the platform release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Old SDKs learn about a retired endpoint only from a new release. Reading the Deprecation header lets any endpoint announce itself, so warnings stop being hardcoded in email.py. Warns once per method and path template per process.