Skip to content

feat(sdk): drop language from ExtractResult - #55

Closed
yudelevi wants to merge 2 commits into
mainfrom
chore/extract-no-language
Closed

yudelevi wants to merge 2 commits into
mainfrom
chore/extract-no-language

Conversation

@yudelevi

@yudelevi yudelevi commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

The API stops returning language from /extract in its next release. Released SDKs default the field to None, so nothing breaks; this keeps check_contract.py clean. Merge after that API release is live.

The API removes the field from /extract, so the contract check would
flag it once that release is live. Merge after the platform release.
yudelevi added a commit that referenced this pull request Nov 10, 2026
The contract check against the platform's development spec failed on
the contacts run models, which still carried flat rows and internal
step fields the API stopped sending and lacked the progress, totals,
filters, email state and stop reason it now returns, and on discover
and count, which did not know valid_mx. Regenerating the request models
from that spec also picks up the larger server default for max_records
and clears suggested_email from PENDING_PROPERTIES now that the spec
carries it. ExtractResult.language stays for #55.
@yudelevi

Copy link
Copy Markdown
Contributor Author

Superseded: the same ExtractResult language removal is already on development (50f20c7, 964c169) and ships in #56.

@yudelevi yudelevi closed this Nov 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant