Repository navigation
feat(admin): warn when a host's webhooks never carry comment events - #27
Merged
Merged
Conversation
A GitLab system hook sends merge request events but never comments, so with only a system hook, @bot commands and learnings fail silently: deliveries are green and nothing points at the cause. From the verified webhook history, the Code hosts page now flags a host that receives deliveries but no comment events, with a platform-specific fix (system-hook-only GitLab hosts get the system hook explanation). Setup gets an optional "Receive comments" step once deliveries arrive. The Add webhook hint and docs/gitlab.md say a system hook alone is not enough. Closes #25 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #25. With only a GitLab system hook, merge request events arrive but comments never do, so
@botcommands and learnings fail silently.HookStatssummarises verified deliveries per host from the webhook history:note, GitHubissue_commentandpull_request_review_comment, Bitbucketpullrequest:comment_created);System Hookdeliveries.Unverified deliveries don't count.
docs/gitlab.mdsay a system hook alone isn't enough. A system hook plus group hooks is fine, since the console drops the duplicate MR event.Not done: the issue's suggestion 2, checking hooks through the GitLab API. It needs Maintainer access on each project or group. The history-based warning catches the reported case without that.
Testing
make test-db(Postgres 17) passes.TestCommentEventsWarning: no deliveries means no warning; system-hook-only shows the warning (an unverified note doesn't count); the Setup step appears; a verified note clears both.TestCommentWarningText: GitHub, Bitbucket, and GitLab with group hooks.TestHookStats(Postgres).🤖 Generated with Claude Code