Repository navigation
Conversation
The panel could only manage a key when neither CODEREVIEW_CONSOLE_LICENSE nor license.file was set, and the docker and kubernetes executors refused to start without a license, so a fresh install couldn't reach the panel to add one. - The key in the database (the panel) now wins over license.file. license.file is deprecated: when the database has no key, a valid key from it is copied in once (audited), then ignored with a warning. Without a database it is read as before. - CODEREVIEW_CONSOLE_LICENSE stays as an override (e.g. when nobody can sign in) and the panel says so. - Without the executors feature the console starts anyway. Review jobs are refused with a clear error, checked per job, so a key added in the panel applies without a restart. The panel shows "reviews are paused" and Setup makes the license step required. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First step of "the console is where the system is configured": the license.
Where the key comes from
CODEREVIEW_CONSOLE_LICENSElicense.filelicense.file (initial)), then ignored with a warning. Without a database it's read as before.Executor licensing no longer blocks startup
executor.type: docker|kubernetesand noexecutorsfeature, the console starts and logs an error instead of exiting.licensedExecutorwrapper refuses each review job with a clear error, and checks per job. A key pasted in the panel applies with no restart./admin/api/mecarriesreviews_paused. The panel shows a red banner linking to License, and Setup makes the license step required.check-configstill reports the missing feature.This also resolves the first-start problem from #18: the panel is reachable without a key.
Upgrade note: installs that renew by replacing the
license.fileSecret should paste the new key in the panel instead. After the first start the file is ignored, and a warning in the log says so.Testing
go test ./...passes.cmd/console/main_test.go:licensedExecutorrefuses jobs until a key withexecutorsis installed, then runs, with no restart.TestReviewsPausedWithoutExecutorLicense:/meand Setup when paused, licensed, and with the local executor.🤖 Generated with Claude Code