Repository navigation
AOT 6: Validate localized authentication resources in Abstractions builds - #4819
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The parameterization is correctly wired, preserves existing behavior, and has focused regression coverage.
0 open findings
What changed in this PR
Adds reusable localization validation for Abstractions while preserving existing SqlClient validation.
Changes:
- Parameterizes resource paths and allowlist sections.
- Adds Abstractions validation and an independent allowlist.
- Adds Pester coverage for selection and pipeline wiring.
| File | Description |
|---|---|
validate-localization-step.yml |
Accepts explicit validation inputs. |
validate-localization.ps1 |
Selects the requested allowlist section. |
validate-localization.Tests.ps1 |
Tests section selection and rejection. |
pipeline-invocation.Tests.ps1 |
Verifies template contracts and wiring. |
build-buildproj-job.yml |
Enables Abstractions validation. |
onebranch-pipeline-design.instructions.md |
Documents both validation gates. |
LocalizationValidationAllowlist.json |
Adds the Abstractions allowlist section. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
paulmedynski
changed the title
paulmedynski
added
the
Area\Azure Connectivity
paulmedynski
changed the title
paulmedynski
force-pushed
the
dev/paul/aot/phase-1.5
branch
from
October 14, 2026 11:36
eece17e to
7928b87
Compare
| parameters: | ||
| resourcesDirectory: src/Microsoft.Data.SqlClient.Extensions/Abstractions/src/Resources | ||
| allowlistSection: AbstractionsAllowedEnglishValueMatches | ||
| failOnValidationError: ${{ parameters.failOnValidationError }} |
paulmedynski
changed the title
This was referenced Oct 14, 2026
paulmedynski
force-pushed
the
dev/paul/aot/phase-1.5
branch
from
October 16, 2026 18:04
d992b08 to
d9493ff
Compare
Comment on lines
+15
to
+16
| /// static initialization. Authentication configuration is covered by the | ||
| /// dedicated AuthenticationTests configuration-process harness. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev/paul/aot/phase-1.4 #4819 +/- ##
==========================================================
- Coverage 65.52% 65.49% -0.04%
==========================================================
Files 285 285
Lines 68296 68296
==========================================================
- Hits 44754 44732 -22
- Misses 23542 23564 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
paulmedynski
force-pushed
the
dev/paul/aot/phase-1.5
branch
from
October 19, 2026 17:13
d9493ff to
3cfdc0b
Compare
paulmedynski
changed the title
Comment on lines
+56
to
+57
| /// configuration only on .NET Framework; the dedicated AuthenticationTests | ||
| /// harness also covers untrimmed .NET configuration loading. |
paulmedynski
force-pushed
the
dev/paul/aot/phase-1.5
branch
from
October 19, 2026 19:07
3cfdc0b to
332f2bc
Compare
paulmedynski
force-pushed
the
dev/paul/aot/phase-1.5
branch
from
October 29, 2026 14:02
332f2bc to
23c504e
Compare
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Validate Abstractions' localized authentication resources in the build pipeline.
Why?
Authentication resources need the same localization checks as driver resources, with independent exception lists so an allowance for one assembly cannot hide a problem in another.
How