Skip to content

[Scheduled Run] Localized resource files from OneLocBuild - #4944

Merged
cheenamalhotra merged 1 commit into
mainfrom
dev/automation/onelocbuild
Oct 30, 2026
Merged

cheenamalhotra merged 1 commit into
mainfrom
dev/automation/onelocbuild

Conversation

@cheenamalhotra

@cheenamalhotra cheenamalhotra commented Oct 29, 2026 •

Copy link
Copy Markdown
Member

Automated PR created from the OneLocBuild scheduled pipeline run.

Contains updated localized Strings.*.resx resource files.

This pull request is refreshed in place by every scheduled localization run, so
there is only ever one open localization PR. Merging it lets the next run start
from a clean base; leaving it open simply keeps it up to date.

  • Branch: dev/automation/onelocbuild
  • Last updated: 2026-10-29 19:53 UTC

Copilot AI balanced review requested due to automatic review settings October 29, 2026 17:01
@cheenamalhotra
cheenamalhotra requested a review from a team as a code owner October 29, 2026 17:01
@github-project-automation github-project-automation Bot moved this to To triage in SqlClient Board Oct 29, 2026
@cheenamalhotra cheenamalhotra added this to the 8.0.0-preview1 milestone Oct 29, 2026
@cheenamalhotra cheenamalhotra moved this from To triage to In review in SqlClient Board Oct 29, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The three added diagnostic messages remain in English across all 13 culture-specific resource files, leaving them unlocalized and triggering localization validation failures.

1 open issue
What changed in this PR

This scheduled OneLocBuild update synchronizes 13 culture-specific SqlClient resource files with three diagnostic messages. No driver logic or public APIs change.

Changes:

  • Adds the Azure attestation extension package requirement message.
  • Adds guidance for unsupported Prepare calls with optimized parameter binding.
  • Adds the explicit locale identifier requirement for character/text metadata in globalization invariant mode.
File Description
src/​Microsoft.Data.SqlClient/​src/​Resources/​Strings.zh-Hant.resx Adds three entries to Traditional Chinese resources.
src/​Microsoft.Data.SqlClient/​src/​Resources/​Strings.zh-Hans.resx Adds three entries to Simplified Chinese resources.
src/​Microsoft.Data.SqlClient/​src/​Resources/​Strings.tr.resx Adds three entries to Turkish resources.
src/​Microsoft.Data.SqlClient/​src/​Resources/​Strings.ru.resx Adds three entries to Russian resources.
src/​Microsoft.Data.SqlClient/​src/​Resources/​Strings.pt-BR.resx Adds three entries to Brazilian Portuguese resources.
src/​Microsoft.Data.SqlClient/​src/​Resources/​Strings.pl.resx Adds three entries to Polish resources.
src/​Microsoft.Data.SqlClient/​src/​Resources/​Strings.ko.resx Adds three entries to Korean resources.
src/​Microsoft.Data.SqlClient/​src/​Resources/​Strings.ja.resx Adds three entries to Japanese resources.
src/​Microsoft.Data.SqlClient/​src/​Resources/​Strings.it.resx Adds three entries to Italian resources.
src/​Microsoft.Data.SqlClient/​src/​Resources/​Strings.fr.resx Adds three entries to French resources.
src/​Microsoft.Data.SqlClient/​src/​Resources/​Strings.es.resx Adds three entries to Spanish resources.
src/​Microsoft.Data.SqlClient/​src/​Resources/​Strings.de.resx Adds three entries to German resources.
src/​Microsoft.Data.SqlClient/​src/​Resources/​Strings.cs.resx Adds three entries to Czech resources.

Review effort: Balanced

@cheenamalhotra
cheenamalhotra enabled auto-merge (squash) October 29, 2026 17:09
@cheenamalhotra
cheenamalhotra force-pushed the dev/automation/onelocbuild branch from bd1dbff to 26f6252 Compare October 29, 2026 19:53
Copilot AI balanced review requested due to automatic review settings October 29, 2026 19:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Maintainer verification is needed because no trusted, immutable source for required supplemental review policies was established, limiting review to supplied diffs and resource consistency checks.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

@codecov

codecov Bot commented Oct 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.18%. Comparing base (c76d081) to head (26f6252).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4944      +/-   ##
==========================================
- Coverage   67.68%   66.18%   -1.51%     
==========================================
  Files         311      305       -6     
  Lines       45249    68282   +23033     
==========================================
+ Hits        30629    45195   +14566     
- Misses      14620    23087    +8467     
Flag Coverage Δ
CI-SqlClient ?
PR-SqlClient-Project 66.18% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mdaigle
mdaigle enabled auto-merge (squash) October 29, 2026 22:06
@mdaigle
mdaigle disabled auto-merge October 29, 2026 22:06
@cheenamalhotra
cheenamalhotra merged commit 5d17a35 into main Oct 30, 2026
125 checks passed
@cheenamalhotra
cheenamalhotra deleted the dev/automation/onelocbuild branch October 30, 2026 03:25
@github-project-automation github-project-automation Bot moved this from In review to Done in SqlClient Board Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants