Skip to content

Add an IDE integration reviewer - #20792

Merged
T-Gro merged 12 commits into
mainfrom
t-gro-vs-service-reviewer
Oct 16, 2026
Merged

T-Gro merged 12 commits into
mainfrom
t-gro-vs-service-reviewer

Conversation

@T-Gro

@T-Gro T-Gro commented Oct 16, 2026

Copy link
Copy Markdown
Member

Adds @ide-integration for changes under vsintegration, the compiler service, and compiler symbols.

@expert-reviewer keeps type checking, IL, pickle, and FSharp.Core, and invokes this reviewer when the diff touches those trees. The rest of the compiler stays with @expert-reviewer.

T-Gro and others added 10 commits October 13, 2026 15:31
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: fc90eb51-8c77-459a-a9eb-63c55bff56ff
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: fc90eb51-8c77-459a-a9eb-63c55bff56ff
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: fc90eb51-8c77-459a-a9eb-63c55bff56ff
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: fc90eb51-8c77-459a-a9eb-63c55bff56ff
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: fc90eb51-8c77-459a-a9eb-63c55bff56ff
The moved IDE and FCS blocks stay in vsintegration-reviewer. Pointers no longer replace sentences that still belong here.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: fc90eb51-8c77-459a-a9eb-63c55bff56ff
Drop Pack A and Pack B. Each tree's rules live in the file named for that tree.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: fc90eb51-8c77-459a-a9eb-63c55bff56ff
The invoke name no longer says VS. Tree files stay named for their folders.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: fc90eb51-8c77-459a-a9eb-63c55bff56ff
Two review rounds. Applied the shorter fixes that at least two reviewers agreed on. Dropped rules with no current code oracle.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: fc90eb51-8c77-459a-a9eb-63c55bff56ff
Restore the editor routing row, keep LanguageServer out of this corpus, and drop the removed ResourceAssembly symbol.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: fc90eb51-8c77-459a-a9eb-63c55bff56ff
Name the members and host contracts that exist now: PEReference, ProvideBindingPath, GoToDefinition, and the surface-area baseline.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: fc90eb51-8c77-459a-a9eb-63c55bff56ff
@T-Gro
T-Gro requested a review from abonie October 16, 2026 09:39
A claim check does not see a copied heading number. The extraction gate now fails that leftover before a panel can call the files clean.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: fc90eb51-8c77-459a-a9eb-63c55bff56ff
@github-project-automation github-project-automation Bot moved this from New to In Progress in F# Compiler and Tooling Oct 16, 2026
@T-Gro
T-Gro merged commit 50f5f30 into main Oct 16, 2026
4 of 5 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in F# Compiler and Tooling Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants