Repository navigation
Conversation
Keep record and opaque type rename edits on identifier tokens without changing Find All References discovery. Cover copy/update expressions, signatures, dependent projects, lexical edge cases, and both compiler/search modes. Resolve the CODE-QUALITY verification blocker with a complete Release compiler/editor dependency build. Document pinned-SDK host selection, desktop test utility targets, consistent bootstrap-redirection settings for build and test, and the SDK-hosted XAML source-embedding option. No architecture or reuse defect was identified in the reviewed production change. Validation: Release FSharp.slnx and FSharp.Editor.Tests builds succeeded with zero errors and BuildProjectReferences=true, using the exact SDK-hosted recipe in DEVGUIDE.md. All 46 editor rename/FAR tests and all 69 FCS FindReferences tests passed, including all 43 added cases. dotnet fantomas . completed without changes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
✅ Release notes checked
|
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 20b10bf6-6a7c-483a-8d09-d521e7ddd73d
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #20791.
Record-type rename filters semantic record-construction and copy/update references that do not contain an editable type-name token. Find All References keeps those references. The editor provider tests cover discovery, preview locations, applied source, and compilation, including signature and dependent-project paths.
Fresh dependency-enabled compiler/editor builds and all 115 focused editor/FCS tests pass with the locally built FSharp.Core, including a fresh run on the final published head. Source-built resource-generation tasks were hash-pinned in an isolated snapshot to avoid locking their own build outputs. Rendered Visual Studio UI and comparison against the reporter's installed binaries remain unverified; no compatible Visual Studio installation is available here.
Checklist