core/plugins/quota: warn that a block-scoped limit shadows userdb overrides - #1606
Open
rokokol wants to merge 1 commit into
Open
core/plugins/quota: warn that a block-scoped limit shadows userdb overrides#1606rokokol wants to merge 1 commit into
rokokol wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Per-User Quota examples override
quota_storage_sizefrom userdb, and the page's main example deliberately keeps that setting outside thequota { .. }block ("Keep this setting outside the quota { .. } to allow easily overriding it in userdb lookups"). What the page never states is what happens when the limit is declared inside the block: the block-scoped value shadows the flat userdb override, which is then silently ignored — whiledoveadm user, which this section recommends for verification, still echoes the field back as if it had taken effect.Measured on stock 2.4.4 with a passwd-file userdb, both directions:
userdb_quota_storage_size=100Moverrides a top-levelquota_storage_size = 1Gand is ignored when the limit is declared inside a named block;userdb_quota/<name>/storage_sizeaddresses the block-scoped limit.This trips users migrating from 2.3, where the limit commonly lived inside
plugin { quota_rule = ... }— see e.g. Quota plugin: "quota_storage_size" not recognized from userdb extra fields in dovecot 2.4.1 on the mailing list.This adds a warning box to the Per-User Quota section naming the failure mode and the path form that addresses a block-scoped limit.