Node lab - #161
Conversation
- add clean/min/lint - remove shell/bin tooling
|
just finished migrating the slick tests, so that completes the original vision of what i wanted to share. hope it helps! |
|
AWESOME work and very helpful suggestions to revive the long list of tests that were collected in these last 20 years. I am going to review your work on the test streamlining/unifying and comment in case something pops up. |
|
Thank you for the work on consolidating the browser tests. Closing this as superseded by #167, which added the pinned WPT suite, Playwright runner, and Node test tooling, and #212, which added Vitest, Oxlint, Oxfmt, and the compatible Rolldown build. Both PRs are merged. This replaces the proposed tooling direction; it is not a claim that every legacy test migration in this PR was carried over. |
This PR starts migrating the browser test suite to a Playwright-based harness and moves the project toward a more Node-centric workflow.
I originally intended to add a regression test, but after reviewing the existing browser test setup, it made more sense to begin consolidating the older browser-driven tests into a single Playwright harness. The previous browser tests were spread across several formats and entry points, and this PR starts centralizing them.
The new harness runs
NW.Domacross multiple browser engines under a single runner, and a large portion of the existing suite has already been migrated. The main remaining piece is theslickfolder, which still contains many specs.During migration, anything clearly broken or needing closer review was marked
fixme. After rebasing onto the latest upstream changes, a few additional failures appeared; I left those red so they can be reviewed directly.This work also pushes the project toward a more Node-centric setup. Along the way, I replaced some shell-driven pieces with Node-based scripts. Not all of those changes were strictly necessary, and since I do not fully know which parts of the previous setup are still important to preserve, that area is especially worth reviewing.
There is a README in
test_new/browser/with notes on the setup, usage, and structure of the harness.Also important to note is that this is not a lossless migration of the older browser tests. I tried to preserve the important behavior and coverage, but some original per-case diagnostics and embedded HTML metadata did not carry over.