Skip to content

Anchor the :required and :optional tests, and let :optional take a button - #191

Merged
jdalton merged 2 commits into
dperini:masterfrom
jdalton:fix/optional-anchors
Sep 7, 2026
Merged

Anchor the :required and :optional tests, and let :optional take a button#191
jdalton merged 2 commits into
dperini:masterfrom
jdalton:fix/optional-anchors

Conversation

@jdalton

@jdalton jdalton commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Fix

Match complete control names, include buttons in :optional, and ignore required on input types where it does not apply.

Tests

Fifteen focused tests cover misleading custom-element names, buttons, input types, attribute changes, and cached select/match queries. Local checks pass: lint, formatting, types, 335 Node tests, and all 42 WPT pages with unchanged coverage thresholds. Rebased on master after #190.

@jdalton
jdalton force-pushed the fix/optional-anchors branch 2 times, most recently from da1d55f to ba18c39 Compare September 5, 2026 02:48
@jdalton

jdalton commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator Author

This one sits with #190 and #192 and #193, which touch the conformance fixes found by comparing against Chromium.

They do not depend on each other. All seventeen in the series cherry-pick onto master in any order, and I checked that in both directions, so any one of these can land alone. The order below is the one they read best in:

  • #190 makes :enabled the complement of :disabled, fieldsets included.
  • #191 anchors the :required and :optional tests, and lets :optional take a button.
  • #192 makes a fieldset :valid when none of its controls is invalid.
  • #193 makes every built-in element :defined.

@jdalton
jdalton force-pushed the fix/optional-anchors branch from 1d06a28 to 508f5e8 Compare September 6, 2026 14:23
@jdalton
jdalton merged commit 47cc8f0 into dperini:master Sep 7, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant