Preserve valid items in forgiving selector lists - #199
Merged
Conversation
This was referenced Sep 5, 2026
jdalton
force-pushed
the
fix/forgiving-list-items
branch
2 times, most recently
from
September 6, 2026 03:04
3881157 to
6cd3b70
Compare
jdalton
force-pushed
the
fix/forgiving-list-items
branch
from
September 6, 2026 04:21
6cd3b70 to
bc479ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Preserve valid items in forgiving :is() and :where() lists. Split only at top-level commas, preserve quoted and escaped commas, and clear compiled resolvers when FORGIVING changes.
Validation
Refreshed onto current master as one commit. The complete local Docker CI workflow passes: lint, formatting, clean type checks, package compatibility, Node tests, native Chromium comparisons, WPT on both builds, and aggregated coverage thresholds. Regression assertions are unchanged; the existing hexadecimal class-escape expected failure remains explicit.
The earlier jsdom mutation timeout is resolved by the reentry guard already on master. No timeout was raised. Test commands are in test/forgiving-list-testing.md.