Add opt-in legacy DOM reads and regression coverage - #203
Merged
Conversation
jdalton
force-pushed
the
feat/legacy-dom
branch
2 times, most recently
from
September 5, 2026 19:10
81c9493 to
91670d6
Compare
jdalton
marked this pull request as ready for review
September 5, 2026 19:42
jdalton
force-pushed
the
feat/legacy-dom
branch
2 times, most recently
from
September 6, 2026 02:30
4a9bc0b to
b9fa3b7
Compare
jdalton
force-pushed
the
feat/legacy-dom
branch
from
September 6, 2026 11:40
b9fa3b7 to
e0345f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Add opt-in legacy DOM reads, collection filtering, and traversal fallbacks. Mode changes clear query plans; document changes preserve the flag. Modern mode keeps direct reads.
Updated to current master. Disabled, enabled, required, and defined helpers now use the legacy accessors. The three previous expected failures are passing tests. The shared host fixture refreshes live collections after DOM mutations. The merged relative-selector fix uses legacy parent traversal for sibling arguments, with unit and WPT regressions for both sibling combinators.
Validation
This does not transpile JavaScript, polyfill the runtime, or claim that historical browsers were tested. Separate property-read and query-routing optimizations remain outside this PR.
Minimums are now statements 79%, branches 70%, functions 80%, and lines 78%. Added WPT regressions for scoped duplicate IDs, fragments, comment-skipping traversal, raw URLs, namespaced attributes, and form IDs.