Repository navigation
Fix/data explorer scroll leak - #546
Merged
Merged
Conversation
Visiting the Data Explorer once removed the right-hand scrollbar from every
page opened afterwards (most visibly the long database service config
screen) until a hard refresh. The explorer stylesheet declared
::ng-deep .mat-sidenav-content, ::ng-deep .mat-drawer-content {
height: 100% !important; overflow: hidden !important; ...
}
without a :host prefix, so it is emitted as a global rule and matches the
app shell's own mat-sidenav-content, which is the element that scrolls
every page. Angular 16 does not remove a component's <style> when the
component is destroyed (REMOVE_STYLES_ON_COMPONENT_DESTROY defaults to
false until v17), so once the explorer had rendered the rule stayed in the
document for the rest of the session. Verified live: removing that one
<style> tag restored overflow: auto on the shell.
The rule now targets the explorer's own container only
(:host ::ng-deep .explorer-sidenav-container > .mat-drawer-content). The
same audit found five more unscoped ::ng-deep rules that leak globally the
same way; they are cosmetic but fixed here too:
- df-roles-access forced .cdk-overlay-pane to width: max-content for every
overlay in the app after a visit. Replaced with a component-level
MAT_SELECT_CONFIG { panelWidth: null }, which is the supported way to let
those select panels size to their content.
- df-dashboard-card styled every [prompt] element app-wide; now :host-scoped
(the prompt row is projected content, so ::ng-deep is still needed).
- df-service-details recolored expansion indicators and select arrows
app-wide; now :host-scoped.
- df-manage-table restyled keyboard-focused sort headers app-wide; now
:host-scoped.
Prior release lines (1.4.x, 1.5.x, 1.6.x) were audited for the same
pattern and carry none of these, so this only affects 1.7.0 onward.
Covers the two user-visible symptoms of unscoped ::ng-deep rules: the shell losing its scrollbar after a Data Explorer visit, and the roles access screen widening every overlay pane in the app. Both run against a live instance like the rest of the suite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.