Repository navigation
Fix/data explorer service labels - #548
Merged
Merged
Conversation
…ow cap
The database selector showed the service label over its raw type, and
most labels are just the type again ("mysql" over "mysql"), so a page of
connections was unreadable. It also capped the service query at 100
rows, silently dropping the rest on larger instances, and never filtered
inactive services because is_active was not requested.
- Show the service name first, with the service type label ("MySQL",
"SQL Server") beneath it; the description or a distinct label moves to
the tooltip. The header above the grid uses the same name.
- Request all database services (server page size) with is_active.
- Add a search box once the list exceeds eight entries.
- Rows are keyboard-focusable and open on Enter.
Checked against 139 active database services.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.