Repository navigation
Fix/api key reach collapsed - #549
Merged
Merged
Conversation
A key whose role spans many services turned the detail page into a
scroll of expansion panels: with 152 reachable services the page was
7,100 px tall and the reach map alone 6,400 px of it. The section now
starts closed, and its header shows what it holds ("152 services, 152
grants") so nothing is lost by not opening it. The scope map stays in
the DOM so the summary resolves without a click.
- df-scope-map emits a `loaded` summary once reach is resolved.
- Show/Hide toggle with aria-expanded; the summary comes from the map.
- Guard the snackbar call in create mode, where there is no app yet
(null dereference surfaced by the spec).
- Spec: provide MatSnackBarModule so the suite runs again; add a test
for the collapsed state and the toggle.
Checked against a role reaching 152 services: page height 7,106 px
before, 1,028 px after, all 152 panels still render when opened.
Rows showed the service label, and most labels are just the type
("mysql" over and over), so a wide role read as a list of identical
entries. Show the name, with a differing label as the hover title.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.