Collaborative script editing: line and text editing on the draft (Phase 3, Step 3) by Tim020 · Pull Request #1479 · dreamteamprod/DigiScript

Tim020 · 2026-10-26T12:08:36Z

Summary

Draft-aware line editing for client-v3's collaborative script editor: a useYTextField composable for caret-anchored live text binding, CollabScriptLineEditor.vue/CollabScriptLinePart.vue as draft-aware siblings of the classic editor components (writes go straight through useDraftWriter the moment they happen), and _uid-keyed open-editor tracking plus add/insert/delete line in CollabScriptEditor.vue.
D1 decided (Tim): incomplete lines keep the atomic abort on save, implemented in Step 4; this step adds the client-side Vuelidate gating so Save can disable itself with a reason once it exists.
Found while landing this step's own E2E, not a bug: once a line is actually edited the draft becomes dirty and (per D9) persists across Stop Editing, so turning collaborative_script_editing back off is blocked until the draft is discarded — there's no Discard-draft UI yet (Step 5). Spec 15's own test cleanup now calls the existing admin REST endpoint directly; documented in the plan doc as expected behaviour while the setting stays hidden.

Test plan

290 Vitest (27 new), tsc/eslint/prettier/build clean
Full Playwright suite, both chromium and firefox, 238/238, no retries
Spec 15 extended: add a dialogue line with act/scene/character/text; typed text survives a reload (proves it's written to the shared draft, not local state); insert and delete a line from a row's menu

🤖 Generated with Claude Code

https://claude.ai/code/session_01TjTnfchFvvQvKZUZv2jpT8

…se 3, Step 3) Draft-aware line editing for client-v3's collaborative script editor, writing straight through useDraftWriter the moment each change happens rather than staging in local state: - useYTextField: binds a text input to a live Y.Text, keeping it in sync with remote edits and anchoring a focused caret to its character (via Yjs relative positions) rather than a raw index, so a concurrent edit earlier in the field doesn't make the caret jump. Distinguishes local vs remote writes by transaction origin so only remote edits need the caret actively restored. - CollabScriptLineEditor.vue / CollabScriptLinePart.vue: draft-aware siblings of the classic ScriptLineEditor/ScriptLinePart, since those are local-state and index-based with no Yjs awareness. Act/scene/character/style selects and part add/remove write directly through useDraftWriter; Vuelidate validation mirrors the classic rules. - CollabScriptEditor.vue: wires ScriptLineViewer's existing edit/insert/delete emits to the new editor, _uid-keyed open-editor tracking (no shift-reindexing needed on insert/delete, unlike the classic index-keyed version), and the Add Dialogue/Stage Direction/Cue Line/Spacing button group. D1 decided (Tim): incomplete lines keep the atomic abort on save (Step 4), with client-side Vuelidate gating added here so Save can disable itself with a reason — implemented in Step 4 since there's no Save button yet. Found while landing this step's own E2E, not a bug: once a line is actually edited the draft becomes dirty, and per D9 (Stop Editing keeps the draft) that persists to disk when the last editor leaves. has_unsaved_changes() then blocks turning collaborative_script_editing back off until the draft is discarded, and there's no Discard-draft UI yet (Step 5) — spec 15's own cleanup now calls the existing admin REST endpoint directly. Documented in the plan doc. Verified: 290 Vitest (+27), tsc/eslint/prettier/build clean, full Playwright 238/238 in both chromium and firefox, no retries. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TjTnfchFvvQvKZUZv2jpT8

github-actions · 2026-10-26T12:09:07Z