Repository navigation
feat(nuxt): use druxt 0.25.0 and its server cache - #170
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 49 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #170 +/- ##
========================================
Coverage 90.24% 90.24%
========================================
Files 13 13
Lines 2132 2132
Branches 103 103
========================================
Hits 1924 1924
Misses 203 203
Partials 5 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
druxt-site ^0.15.0 brings the released druxt 0.25.0, which installs as a single top-level druxt, so the Nuxt build resolves it again. druxt-auth 0.5.1 admits the axios 0.34 that druxt 0.25.0 needs. The CORS comment now names the case that stops caching: credentials with the * origin.
Decipher
changed the title
druxt 0.25.0 keeps module data such as a region's name out of the wrapper markup, so the end-to-end tests no longer found div[blocks][name=...]. The Olivero layout now wraps each region that has blocks in a div with the class Drupal's Olivero theme gives it, such as region--primary-menu, and the tests select those.
Decipher
marked this pull request as ready for review
October 23, 2026 06:16
The installers set Drupal's page cache max-age to 60, but a site installed before keeps its old value, 0 by default, and the server cache keeps nothing. The caching section gives the two drush commands that set it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the quickstart to Druxt 0.25.0 and sets it up to use the 0.25.0 server cache.
Changes
druxt-siteat^0.15.0, which brings every Druxt package at 0.25.0 with one top-leveldruxt. develop's lockfile had five copies ofdruxtacross 0.22, 0.23 and 0.24.druxt-authat^0.5.1, which admits the axios 0.34 that druxt 0.25.0 needs.no-cacheand the server cache keeps nothing.supportsCredentials. WithallowedOrigins: ['*'], credentials make every responseVary: Origin, which Druxt never caches. Sign-in uses OAuth bearer tokens, so nothing needs credentialed CORS.druxt.schema.refresh, so a display changed in Drupal shows after a cache clear without a rebuild.druxt.cache.secretfromDRUXT_CACHE_SECRET, optional, for Drupal to clear the cache. README and.env.examplecover it.divwith the class Drupal's Olivero theme gives it, such asregion--primary-menu. druxt 0.25.0 keeps a region's name out of the wrapper markup, so the end-to-end tests select these classes instead ofdiv[blocks][name=...].Checked
With Node 16.18.1 and npm 8.19.2,
npm installgives one top-leveldruxt0.25.0,druxt-site0.15.0,druxt-auth0.5.1 and axios 0.34.0, with no nested copy ofdruxt.npm run lint,test:unit,test:scripts, prettier, cspell, markdownlint andlint:privatepass. The CI install and end-to-end jobs build and run it against Drupal.On the 0.25.0 development release, with the same configuration, a repeat render didn't request the index or menus,
POST /_druxt/cache/clearanswered 401 for a wrong secret and 204 for the right one, and a renamed field label showed after a clear and not before.Summary by CodeRabbit