Skip to content

Add subaccount permissions to integration - #314

Open
vasyl-smoliak wants to merge 3 commits into
duosecurity:masterfrom
vasyl-smoliak:add_subaccount_permissions
Open

Add subaccount permissions to integration#314
vasyl-smoliak wants to merge 3 commits into
duosecurity:masterfrom
vasyl-smoliak:add_subaccount_permissions

Conversation

@vasyl-smoliak

Copy link
Copy Markdown

Description

Adds new permissions to create_integration and update_integration, so callers can grant an Admin API application access to subaccounts.
Docs are also updated to reflect that the Accounts API no longer exists and has been merged with the Admin API

Motivation and Context

The Admin API accepts new parameters on integration create and update related to subaccount permissions, but the client had no way to send them — callers had to bypass the wrapper and hand-build requests, or drop to json_api_call directly.

How Has This Been Tested?

Automated tests added

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Comment thread duo_client/admin.py
account_id assigned) this argument is ignored and the
client's own account is the one deleted.
"""
params = {

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an alternative, we could raise an exception here if the account_id is not equal to self.account_id.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a preference; I'll let you decide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants