Repository navigation
fix: align Jackson patch and verify main in CI - #5
Merged
Merged
Conversation
loong10k
marked this pull request as ready for review
November 3, 2026 23:37
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main currently receives no build CI, and the auto-active JDK profile silently overrides the root Jackson property with 2.22.0. Updating only the root property in bot PR #3 therefore does not update the runtime dependency.
Use one Jackson 2.22.4 property, enable push/PR CI for main while preserving the existing feature trigger, and fail Surefire when no tests are found. Preserve the mandatory 90% JaCoCo line gate. Add JSON compatibility regressions for request field names, Unicode, null omission, forward-compatible responses and custom think codecs.
Validation: JDK 17
mvn -B --no-transfer-progress clean verifypasses 125 tests, no skips, with 5041/5463 covered lines (92.28%). Effective POM/dependency tree resolves databind/core 2.22.4 and upstream annotations 2.22. No maintenance branches, wrapper, release configuration or credentials changed.Supersedes the dependency change proposed in #3.