Repository navigation
fix: restore HTTP config compatibility and main CI - #5
Merged
Merged
Conversation
loong10k
marked this pull request as ready for review
November 3, 2026 23:16
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main cannot compile its tests because the HTTP config rename removed documented serverUrl accessors and the legacy SSE queue alias. Restore both JavaBean aliases over canonical fields and test bidirectional state, Jackson binding under both names, and JSON round trips without removing existing tests.
Upgrade the Jackson 2 BOM from 2.17.2 to 2.18.12, superseding bot PR #3 (2.18.10). This retains Jackson 2 and JDK 17. Upstream security fixes: https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.18.11 and https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.18.12.
Preserve JaCoCo's prepared agent in Surefire argLine. JDK 17 clean verify: 263 tests passed, none skipped; real line coverage 758/1353 (56.02%). Existing 90% warning policy is unchanged and is not met.
History: 1be6194 renamed serverUrl to baseUrl while README and callers retained the old contract. Only main is targeted; no wrapper, release, or security settings changes.