Repository navigation
fix: initialize optional coverage args and test JSON alias boundaries - #6
Merged
Merged
Conversation
loong10k
marked this pull request as ready for review
November 3, 2026 23:23
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Direct surefire:test fails to start its JVM when JaCoCo prepare-agent has not initialized @{argLine}. Define an empty default while retaining late agent substitution for normal verify. CI now runs direct Surefire and tests with jacoco.skip=true after the coverage build.
Add separate JSON regressions for canonical/legacy equal output, both conflicting input orders (last property in document order wins), and nested HTTP config binding. No serialization behavior is changed: current main emits both names. Historical pre-rename code emitted serverUrl; the rename emitted baseUrl. Selecting canonical-only output would need a separate compatibility decision.
JDK 17 local validation: clean verify, direct surefire:test, and clean verify -Djacoco.skip=true each pass 266 tests, no failures/errors/skips. Normal coverage remains below the unchanged 90% warning threshold (56.02%). No changes to bot PR #3, other version lines, releases, or security settings.