Repository navigation
Conversation
loong10k
marked this pull request as ready for review
November 4, 2026 00:40
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main targets Java 17, but CI still ran Java 8 and Surefire skipped every test. Run the supported JDK 17/21 matrix, remove obsolete PermSize/skip settings, discover the 13 existing JUnit3 tests directly, and exclude their AllTests aggregator to avoid duplicate execution.
Add four JavaScript/CSS compression regressions and reject zero tests, missing/empty/incomplete reports, duplicate tests, failures, errors, and skips. Production code, dependencies, Java 17 baseline and maintenance branches are unchanged.
Validation: local JDK 17 and 21 clean verify each passed 17 tests with zero skips; report verifier confirmed 17 unique tests in three reports. Negative checks rejected missing, empty, duplicate, skipped, failed and incomplete reports; Surefire rejected an unmatched test selection. Existing bot dependency versions are already superseded on main and are not part of this fix.