Implement mittag_leffler model - #244
Open
henrikjacobsenfys wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #244 +/- ##
==========================================
Coverage ? 98.06%
==========================================
Files ? 59
Lines ? 5898
Branches ? 1010
==========================================
Hits ? 5784
Misses ? 59
Partials ? 55
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disclaimer: The code was written by Claude and looked through by me. The description below was written by me.
This implements the diffusion model that was requested at the summer school, eqs. 41 and 42 in this paper
A factor pi is missing in the equation, which is fixed here. Eq. 42 is also a special case of$\tau_R=1$ , here we allow any value of $\tau_R$ .
It is implemented as a ModelComponent for the per-Q calculation and as a DiffusionModel since in the paper$\epsilon=DQ^2$ . It is modelled after the existing DeltaLorentz diffusion model, so the only new things are the equations - all the architecture is essentially copy/pasted. (I don't think it should be put into a shared base class when we have only two models that are similar).
The tests verify numerical correctness by comparing with the Laplace transform given earlier in the paper.
The notebook reproduces several of the figures of the paper, indicating that everything works as it should.