Skip to content

dont show 0.0 for parameter errors where no fitting was done #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rozyczko merged 1 commit into from
Aug 27, 2026
Merged

dont show 0.0 for parameter errors where no fitting was done #397

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/easyreflectometry/summary/summary.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,9 @@
html_parameter = html_parameter.replace('parameter_name', f'{name}')
html_parameter = html_parameter.replace('parameter_value', _format_value(value, 3))
html_parameter = html_parameter.replace('parameter_unit', f'{unit}')
error_str = _format_value(error, 2)
# An unfitted parameter has no uncertainty; a literal '0.0' would
# read as a perfectly determined value, so leave the cell empty.
error_str = _format_value(error, 2) if error else ''

Check warning on line 296 in src/easyreflectometry/summary/summary.py

View check run for this annotation

Codecov / codecov/patch

src/easyreflectometry/summary/summary.py#L296 

Added line #L296 was not covered by tests
html_parameter = html_parameter.replace('parameter_error', error_str)
html_parameters.append(html_parameter)

Expand Down
Loading