Repository navigation
Conversation
|
This needs to be adapted when #627 is merged. |
zrgt
left a comment
zrgt
left a comment
There was a problem hiding this comment.
The spec defines PostAllAssetLinksById as "Creates or replaces all asset links associated to the Asset Administration Shell" (spec). The endpoint currently merges the posted links into the existing ones, and test_post_is_additive asserts that, see #669.
Since this PR already aligns this endpoint with the spec, could it also replace the links instead of merging them, and flip test_post_is_additive?
|
Related to the requested change for #669: both handlers in this PR also maintain the reverse index ( |
Previous status code were not in agreement with the respective specification. This adjust HTTP status codes returned to align.
Previously, `post_all_asset_links_by_id` merged the posted asset links into any already stored for the AAS. The spec however defines `PostAllAssetLinksById` as "creates or replaces" all asset links associated, so the current behaviour is incorrect. Additionally both handlers maintained the reverse index independently. This change: - Folds reverse-index into two central methods - Remves the private helpers - Implemets replace semantics in post_all_asset_links_by_id by calling delete, then add - Flips the test previously covering the "wrong" behaviour
6519444 to
b290942
Compare
This updates `test_asset_links_roundtrip` to assert 201 and makes tearDown handle 404.
Previous status code were not in agreement with the respective specification.
This change adjusts the HTTP status codes.
Fixes #625