[artaleks9]

I noticed in some repos, CI E2E test 'happy-path' failed when waiting the 'starting page loader is disappeared'. Looks like the dashboard page opens slowly, and timeout in 5 sec is not enough.
E.g.:

• https://prow.ci.openshift.org/view/gs/test-platform-results-public/pr-logs/pull/devfile_devworkspace-operator/1734/pull-ci-devfile-devworkspace-operator-main-v14-che-happy-path/2119892935146213376

• https://prow.ci.openshift.org/view/gs/test-platform-results-public/pr-logs/pull/eclipse-che_che-operator/2256/pull-ci-eclipse-che-che-operator-main-v22-devworkspace-happy-path/2120188630394736640

What does this PR do?

The happy-path e2e test fails intermittently at the login stage in the same place: after login, the dashboard starting page loader (.main-page-loader) is still visible when the default 5s TS_COMMON_DASHBOARD_WAIT_TIMEOUT expires:

TimeoutError: Waiting attempts exceeded, element 'By(css selector, .main-page-loader)' is still visible
  at DriverHelper.waitDisappearance (/tmp/e2e/utils/DriverHelper.ts:243:10)
  at async Dashboard.waitStartingPageLoaderDisappearance (/tmp/e2e/pageobjects/dashboard/Dashboard.ts:171:3)
  at async LoginTests.loginIntoChe (/tmp/e2e/tests-library/LoginTests.ts:48:4)

The dashboard page just opens slower than 5 seconds on loaded CI machines.

Changes:

• Increase the default TS_COMMON_DASHBOARD_WAIT_TIMEOUT from 5_000 to 10_000 in tests/e2e/constants/TIMEOUT_CONSTANTS.ts
• Fix the lint error Comments should not begin with an uppercase character for the TS_AI_PROVIDER_API_KEY comment in tests/e2e/constants/BASE_TEST_CONSTANTS.ts (API key -> api key)

Screenshot/screencast of this PR

N/A — configuration constants only.

What issues does this PR fix or reference?

devfile/devworkspace-operator#1734 (comment)

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

• The Eclipse Contributor Agreement is valid
• Code produced is complete
• Code builds without errors
• Tests are covering the bugfix or new feature
• The repository devfile is up to date and works
• Sections What issues does this PR fix or reference and How to test this PR completed
• Relevant user documentation updated
• Relevant contributing documentation updated
• CI/CD changes implemented, documented and communicated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

🤖 Generated with Claude Code

Summary by CodeRabbit

• Tests
  • Automated checks now allow more time for dashboard loading when no custom wait time is configured. This affects test behavior only; there are no changes to the application’s features or behavior.

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

The pull request increases the default dashboard wait timeout from 5,000 ms to 10,000 ms and changes capitalization in a test constant comment.

Changes: E2E test constants

Layer / File(s)	Summary
Test constant values tests/e2e/constants/TIMEOUT_CONSTANTS.ts, tests/e2e/constants/BASE_TEST_CONSTANTS.ts	The dashboard wait timeout default and fallback change to 10,000 ms. A comment changes “API key” to “api key.”

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Merge Risk: Minimal · up to 946b4

The longer default allows more time for dashboard loading. No merge-blocking issue is identified.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly describes the main change: increasing the dashboard wait timeout to stabilize the happy-path E2E test.
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 2 files.

Finishing Touches

Generate docstrings

• Commit to this branch
• Create a new PR

Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: d1280283-cf6d-48d0-bd19-edcdc69c5137

Commits

Reviewing files that changed from the base of the PR and between c0b7f65 and 946b489.

Files selected for processing: 2

• tests/e2e/constants/BASE_TEST_CONSTANTS.ts
• tests/e2e/constants/TIMEOUT_CONSTANTS.ts

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

[dmytro-ndp]

LGTM