Skip to content

GLSP-1823: Publish latest on push of the signed release tag - #151

Closed
tortmayr wants to merge 1 commit into
masterfrom
publish-on-release-tag
Closed

tortmayr wants to merge 1 commit into
masterfrom
publish-on-release-tag

Conversation

@tortmayr

Copy link
Copy Markdown
Contributor

What it does

Publishes a release under the latest dist-tag when its signed tag v<version> is pushed, replacing the dispatch from the umbrella release workflow. glsp releng release (eclipse-glsp/glsp-core#41) pushes this tag once the release PR is merged and CI passed on the release commit. Publishing stays in publish.yml because npm trusted publishing is bound to the workflow file.

  • Run on pushes of v<version> tags and publish under latest after checking that the tag is a final release (v<major>.<minor>.<patch>) matching the package version, that it is signed and verified by GitHub, and that CI passed on the tagged commit
  • Exclude javax tags, which have no npm release
  • Skip next publishes of release versions in the change detection step
  • The manual dispatch stays available as a fallback

Part of: eclipse-glsp/glsp#1823

How to test

The tag-triggered publish runs for the first time with the next real release.

  • The tag checks run against real tags: unsigned annotated and lightweight tags are rejected, signed tags pass
  • The CI guard passes for a commit with green CI and fails for missing and red CI
  • After merge, the nightly next publish still runs and publishes as before

Follow-ups

  • Add a tag ruleset that restricts who can push v* tags
  • Remove prepare-release.yml and publish-release.yml after the first release with the new flow
  • Release the javax variants (v<version>.javax)

Changelog

  • This PR should be mentioned in the changelog
  • This PR introduces a breaking change (if yes, provide more details below for the changelog and the migration guide)

- Publish the client packages under the latest dist-tag when a release
  tag is pushed, after checking that it is a final release tag matching
  the package version, signed and verified by GitHub, and that CI
  passed on the tagged commit
- Exclude javax tags, which have no npm release
- Skip next publishes of release versions in the change detection step

Part of: eclipse-glsp/glsp#1823
@tortmayr

Copy link
Copy Markdown
Contributor Author

Superseded by #150, which now includes the latest publish on push of the signed release tag.

@tortmayr tortmayr closed this Nov 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant