Repository navigation
Conversation
… expose - Cover IdeGLSPClient, IdeMessageConsumer, the model initialization constraint, the marker severity mapping, the key binding forwarding and UrlUtils - Fix MessageAction details showing up as "Optional[...]" in the error log and dialog - Parse message and status severities with a shared helper that treats missing or unknown values as NONE instead of throwing, and map FATAL messages to IStatus.ERROR instead of CANCEL - Return an empty Optional from GLSPEditorRegistry for an unknown editor id instead of throwing a NullPointerException - Encode query parameter keys in UrlUtils and drop a leading slash from the base URL, which produced "//" in the editor URL Fixes eclipse-glsp/glsp#1829
tortmayr
force-pushed
the
improve-unit-tests
branch
from
November 17, 2026 23:17
b3be6a7 to
96b80c6
Compare
fismif
approved these changes
Nov 18, 2026
fismif
left a comment
There was a problem hiding this comment.
LGTM!
I verified this locally:
mvn -f server clean verifypasses: 31 tests, Checkstyle clean.- With the old plugin code put back, the new tests fail as described.
- The workflow example works in a runtime Eclipse: the diagram opens, Ctrl+Z and Ctrl+S are forwarded, and the status bar shows the right icon.
Minor, non-blocking:
GLSPDiagramComposite.encodeParameterstill uses the old"UTF-8"/UnsupportedEncodingExceptionpattern removed fromUrlUtils. It could useStandardCharsets.UTF_8too.- The error dialog still shows the message twice: once as the dialog text and again as the first line of the "Reason" section, because the status text includes the message as well as the details. Not introduced here, but this PR touches that output, so it may be worth fixing.
- Pass only the details as the dialog status when a message has both message and details, since ErrorDialog repeats the status text as "Reason" below the dialog message - Encode parameters in GLSPDiagramComposite with StandardCharsets.UTF_8, dropping the unreachable UnsupportedEncodingException Part of: eclipse-glsp/glsp#1829
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Follow-up of #153 that adds unit tests for the pure logic classes of
org.eclipse.glsp.ide.editorand fixes the bugs they surfaced.IdeGLSPClient,IdeMessageConsumer,DefaultModelInitializationConstraint, the marker severity mapping, the key binding forwarding andUrlUtilsMessageActiondetails showing up asOptional[...]in the error log and error dialogFATALmessages toIStatus.ERRORinstead ofCANCEL, and treat a missing or unknown severity as OK instead of throwingOptionalfromGLSPEditorRegistry.getGLSPServerManagerfor an unknown editor id instead of throwing aNullPointerExceptionUrlUtilsand drop a leading slash from the base URL, which produced//in the editor URLFixes eclipse-glsp/glsp#1829
How to test
org.eclipse.glsp.ide.editor, 6 of the new tests failFollow-ups
ArrowUpare not forwarded to Eclipse key bindings, asARROWUPis no valid Eclipse key nameIdeClientOptions,ResourceUtilChangelog