Match SourceViewer canvas background to text widget - #3965
Open
vogella wants to merge 1 commit into
Open
Conversation
Contributor
|
This looks good to me. Something that might come up is that this "removes" the vertical line between the line number column and the text that some folks might be expecting. However, it looks like it was never intended to be there in the first place, and a few other code editors I looked at (VS Code, Zed) don't put a vertical line there. |
The 1px gap between the vertical ruler and the text widget is rendered by RulerLayout against the parent canvas, which kept its system default background. On dark editor themes this surfaced as a bright vertical strip between the line numbers and the source. Track the StyledText background and apply it to the canvas, so the gap blends into the editor color scheme. Re-syncs on text widget paint events so preference-driven background changes propagate. Fixes eclipse-platform#3964
vogella
force-pushed
the
issue-3964-sourceviewer-gap-bg
branch
from
August 29, 2026 04:23
0faf690 to
c60705f
Compare
Contributor
Author
|
vogella
marked this pull request as ready for review
August 29, 2026 05:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On dark editor themes a bright 1px vertical strip appears between the line numbers and the source code. The strip is the gap that
RulerLayoutleaves between the vertical ruler and the text widget; it exposes the parentCanvasofSourceViewer, whose background was never themed.This change tracks the
StyledTextbackground and applies it to the canvas so the gap blends into the editor color scheme, and re-syncs on text widget paint events so preference-driven background changes propagate.Fixes #3964