callstack: get an experiment analysis to show in the flamechart - #432
callstack: get an experiment analysis to show in the flamechart#432arfio wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe change updates flame-chart provider resolution and time-graph entry-list construction. Provider lookup now uses analysis-module IDs and generic time-graph APIs. Flame-chart-specific function-name resets remain conditional on the provider type. ChangesFlame-chart provider flow
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This localized change enables experiment callstack data to render in flame charts while preserving existing provider lookup behavior; no actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What it does
The flame chart view does not display the experiment data provider if the call stack analysis applies to an experiment. This PR adds the capability
How to test
Open an experiment and run a callstack analysis with the "applies_experiment" of the extension set to true.
Follow-ups
The call to reset function names does not work if the analysis does not apply to an experiment. In this case, because the call is not part of the Data provider API, the composite data provider does not allow it.
Review checklist
Summary by CodeRabbit