Skip to content

fix(netfront): fix queue selection - #125

Merged
bleggett merged 1 commit into
edera/mainlinefrom
bleggett/netfront-xps-queue-select
Nov 20, 2026
Merged

bleggett merged 1 commit into
edera/mainlinefrom
bleggett/netfront-xps-queue-select

Conversation

@bleggett

@bleggett bleggett commented Nov 20, 2026 •

Copy link
Copy Markdown

Back in the previous repo, a patch edera-dev/linux-kernel-oci#182 added XPS-aware netfront queue placement, but that, as far as I can tell, was deadcode and never worked, because it left ndo_select_queue = xennet_select_queue, so TX selection was never intelligently placed, so we got zero queue placement benefits from it, and it fact it prevented us falling through to a more intelligent placement mechanism.

This is a fixup to that change so queue placement actually falls through correctly to optimized placement, which should help TCP throughput consistency a good deal, since we aren't (incorrectly) relying on random placement anymore.

Details:

netdev_core_pick_tx() calls ndo_select_queue when a driver has one, and only netdev_pick_tx() actually consults XPS.

So, xennet_select_queue() ignored the per-node XPS map installed in setup_netfront() , and TX selection stayed as ye olde random skb_get_hash() % num_queues on all nodes.

Deleting the driver hook causes fallthrough to the existing logic where the sender selects queues with node-local rings, which is what we want. We could use a more complex heuristic here, but this alone is better than what we ship.

@bleggett
bleggett force-pushed the bleggett/netfront-xps-queue-select branch from 39124dd to 395f4bb Compare November 20, 2026 18:13

@alexandermerritt alexandermerritt left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay for deleting stuff

@bleggett
bleggett merged commit 1f12a94 into edera/mainline Nov 20, 2026
3 checks passed
@github-actions

Copy link
Copy Markdown

Backport to edera/6.18-lts: waiting

Waiting: earlier Edera commits on edera/mainline that touch the same files are not on edera/6.18-lts yet, and have to be backported first:

This is retried when a backport lands on edera/6.18-lts, and nightly. If one of them should never be backported, label its pull request no-backport, or list its subject in .automation/backport-skip on edera/6.18-lts.

Run log

@bleggett

bleggett commented Nov 20, 2026 •

Copy link
Copy Markdown
Author

Backport to edera/6.18-lts: waiting

Waiting: earlier Edera commits on edera/mainline that touch the same files are not on edera/6.18-lts yet, and have to be backported first:

* `cfdd691d0e41` xen/netfront: netfront persistent grants ([xen/netfront: netfront persistent grants #119](https://github.com/edera-dev/linux/pull/119))

This is retried when a backport lands on edera/6.18-lts, and nightly. If one of them should never be backported, label its pull request no-backport, or list its subject in .automation/backport-skip on edera/6.18-lts.

Run log

???

this is completely wrong. I think the automation broke. looking.

EDIT: it did #127

bleggett added a commit that referenced this pull request Nov 20, 2026
* xen/netfront: netfront persistent grants (#119)

* xen/netif: add the static grant control messages

* xen/netfront: add control ring support

* xen/netfront: register static grant pools with the backend

* xen/netfront: use static grants on the receive path

* xen/netfront: use static grants on the transmit path

* fix(netfront): fix queue selection (#125)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants