Repository navigation
ci(i18n): fallar si el inventario de textos está desactualizado (#155) - #158
Merged
Merged
Conversation
Run `node scripts/i18n-inventory.mjs --check` in the Windows CI job right after the existing tests, so a pull request that changes or shifts text in src/ or src-tauri/src/ must regenerate docs/i18n-inventory.md. The convention is documented in CONTRIBUTING.md and the script header; a contract test pins the step after `npm ci`. The inventory is regenerated because main had drifted since egdev6#156.
1 task done
egdev6
approved these changes
Oct 21, 2026
This was referenced Oct 21, 2026
Open
egdev6
added a commit
to danielgap/quorb
that referenced
this pull request
Oct 21, 2026
egdev6
added a commit
that referenced
this pull request
Oct 21, 2026
* feat(i18n): give meters a stable id across the Rust/JS boundary (#66) Meter labels are Spanish text that JS logic matched on: short ring labels, alert dedupe and reset diffing, ring colors, history lookup and React keys. Translating them would silently break all of that. Add `Meter.id` (session, weekly, credits, model:<id>, ...) at every provider construction site and switch that logic to the id. Labels stay as today, so nothing visible changes. History samples now store the id and still match legacy label samples until they age out; stored alert memory keyed by label is honored so no alert repeats after upgrading. * chore(i18n): regenerar cabecera del inventario tras el merge de main (#158) --------- Co-authored-by: Quique <egdev6@gmail.com> Co-authored-by: egdev6 <egdev6@users.noreply.github.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue / Issue relacionada
Closes #155
ODD: no aplica (tarea
type:choreabierta por el mantenedor tras #152). Acordada en #155 (comment) ("ahi va @danielgap"); el campo de asignación quedó en @egdev6.Scope / Alcance
CI falla si
docs/i18n-inventory.mdno corresponde a los árboles actuales desrc/ysrc-tauri/src/..github/workflows/ci.ymlnode scripts/i18n-inventory.mjs --checkjusto después denpm test, en el job existente (Windows). Sin workflows nuevos.CONTRIBUTING.mdscripts/i18n-inventory.mjsscripts/i18n-inventory.test.mjsci.ymlejecuta--checkdespués denpm ci.docs/i18n-inventory.mdmainestaba desactualizado desde #156.Ojo con dos efectos para quien contribuya (documentados en CONTRIBUTING):
src/tiene que regenerar el inventario. El error muestra el comando exacto.main. Simaincambiósrc/mientras tanto, hay que actualizar la rama y regenerar de nuevo.Fuera de alcance: cambios en el generador o en su heurística, workflows nuevos y cualquier parte de L2/L3 de #66.
npm testsigue sin depender del estado del documento, como pedía la issue.Orden con #159 (T2a de #66): las dos ramas regeneran el inventario. Si esta entra primero, actualizo #159 y lo regenero.
Coordination / Coordinación
Contribuidor: @danielgap
Acceptance and validation / Aceptación y validación
--checken el job actual de CI y convención documentada (la issue pide ambas cosas).node --test scripts/i18n-inventory.test.mjsda 12/12.node scripts/i18n-inventory.mjs --check: exit 1 sobremainantes de regenerar, exit 0 después.npm test: vitest 603/603; scripts de Node 217/221.indexOfy no parsea el YAML;EPERMal crear symlinks en Windows (setup-signing,provision-tools), ajenos a este cambio.