Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .skills/planning-and-closure/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,11 @@ requires contract-level acceptance evidence. `plans/003-planning-process.md` is

## Before you open anything

1. Read `plans/registry.md` §"Next handoff". As of the last review **no
implementation milestone is `ready`** — the next three lines (Contract M003,
Bootstrap M003, Ecosystem M003 eggsearch) are *research/plan decisions*, not
execution. If your idea is one of them, the deliverable is a plan, not code.
1. Read the current `plans/registry.md` status tables and §"Next handoff".
Milestone status changes over time; use the registry and linked subsystem
roadmap as the authority instead of relying on remembered status snapshots.
If no implementation milestone is `ready`, author or update a plan before
implementing work that has not been handed off.
2. Check the subsystem roadmap (`plans/subsystems/<subsystem>-roadmap.md`). A
plan may already exist under a name you did not guess.
3. Only then write anything.
Expand Down
2 changes: 1 addition & 1 deletion AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -89,4 +89,4 @@ Read the index in `overview.md` and follow one link. Grouped by what they cover:
## Planning conventions

- Closure discipline: `plans/closure/<subsystem>/NNN-status.md`. Compilation ≠ closure. History never rewritten — correctives are new `NNNa` plans; superseded material goes to `plans/archive/`.
- Current handoff (source: `plans/registry.md`): no milestone is **in progress** and none is registered **ready**; the last open obligation of the 2026-10-23 review chain — Release Manifest M004, the ADR-0006 `eggpack-manifest 0.1.1` patch release and the compatibility record ADR-0006 §5.4 requires — is **closed**: `0.1.1` is published to crates.io (checksum `352c3e327159615b763298e911e239f1decc4a2c9e28c28be8ddd28e50515e37`, tagged `eggpack-manifest-v0.1.1`), and both narrowings the package carries — the ADR-0006 digest rule and the `3ef806f` document bound — are recorded as compatibility events. The 2026-10-23 post-implementation review chain is closed (Build/Qualification M007, M008, M009; CI/Release M003l, M003m, M003n; Planning Hygiene M003; Bootstrap M003a), and **ADR-0006 is accepted** (Option A), having gated CI M003l's digest-acceptance work package only. A follow-up review of that chain's own output registered and closed a second corrective chain: Build/Qualification M007a (digest zero-length read refusal), M008a (floor contradiction mask and ELF offset overflow), M009a (local producer operator defects, including an input-destroying staging path), and CI/Release M003o (renderer panic and digest diagnostics). **The chain's first hosted CI run failed on macOS and registered a third corrective, CI/Release M003p**: the shared bounded runner treated a failed process-group signal as fatal, but macOS refuses to signal a group holding the unreaped zombie of an exited child and reports `EPERM` where Linux signals it successfully, so an output-bound violation was reported as a launch failure. M003p decides by observing whether the child has exited rather than by reading the errno, and hosted run `40263176191` is green on all four lanes. Both review chains left one obligation open — ADR-0006 §5.2/§9's `eggpack-manifest 0.1.1` publication and the release-manifest compatibility record — and M004 owns it; the `0.1.1` package carries **two** narrowings of the published acceptance set, the ADR-0006 digest rule and the `3ef806f` document bound, and only the first had been recorded. **Blocked** are Ecosystem M004 (Gregg sibling bundle), Ecosystem M005 (CodeGG runfile bundle), and Ecosystem M006 (Egress archive pair), each on its named adoption evidence and bundle/archive review; the provenance/authenticity line is **planned** pending a dedicated trust ADR, and Python/wheel adapters are **planned** behind broader native adoption. Contract M003, Bootstrap M003, and Ecosystem M003a/M003b are closed, so the contract-conformance and bootstrap-installers subsystems have no open work. The next Eggpack line is whatever the registry lists as `ready`; if that table is empty, the next action is plan authoring, not implementation.
- Current handoff (source: `plans/registry.md`): CI/Release M003pa is **closed** under `plans/implementation/ci-release-orchestration/003pa-process-group-signal-recheck-corrective.md`; closure `plans/closure/ci-release-orchestration/003pa-status.md` records implementation `329a3dfdb166580de4770b2c6b2f046358983003` and hosted run `44118309795` green on all four lanes; no implementation milestone is **active** and none is registered **ready**; the next action is plan authoring, not implementation; the last open obligation of the 2026-10-23 review chain — Release Manifest M004, the ADR-0006 `eggpack-manifest 0.1.1` patch release and the compatibility record ADR-0006 §5.4 requires — is **closed**: `0.1.1` is published to crates.io (checksum `352c3e327159615b763298e911e239f1decc4a2c9e28c28be8ddd28e50515e37`, tagged `eggpack-manifest-v0.1.1`), and both narrowings the package carries — the ADR-0006 digest rule and the `3ef806f` document bound — are recorded as compatibility events. The 2026-10-23 post-implementation review chain is closed (Build/Qualification M007, M008, M009; CI/Release M003l, M003m, M003n; Planning Hygiene M003; Bootstrap M003a), and **ADR-0006 is accepted** (Option A), having gated CI M003l's digest-acceptance work package only. A follow-up review of that chain's own output registered and closed a second corrective chain: Build/Qualification M007a (digest zero-length read refusal), M008a (floor contradiction mask and ELF offset overflow), M009a (local producer operator defects, including an input-destroying staging path), and CI/Release M003o (renderer panic and digest diagnostics). **The chain's first hosted CI run failed on macOS and registered a third corrective, CI/Release M003p**: the shared bounded runner treated a failed process-group signal as fatal, but macOS refuses to signal a group holding the unreaped zombie of an exited child and reports `EPERM` where Linux signals it successfully, so an output-bound violation was reported as a launch failure. M003p decides by observing whether the child has exited rather than by reading the errno, and hosted run `40263176191` is green on all four lanes. A later review found that this does not prove the whole group is empty; M003pa is active to retry after reaping the leader and accept only a successful retry or `ESRCH`, keeping every other case fail-closed. Both review chains left one obligation open — ADR-0006 §5.2/§9's `eggpack-manifest 0.1.1` publication and the release-manifest compatibility record — and M004 owns it; the `0.1.1` package carries **two** narrowings of the published acceptance set, the ADR-0006 digest rule and the `3ef806f` document bound, and only the first had been recorded. **Blocked** are Ecosystem M004 (Gregg sibling bundle), Ecosystem M005 (CodeGG runfile bundle), and Ecosystem M006 (Egress archive pair), each on its named adoption evidence and bundle/archive review; the provenance/authenticity line is **planned** pending a dedicated trust ADR, and Python/wheel adapters are **planned** behind broader native adoption. Contract M003, Bootstrap M003, and Ecosystem M003a/M003b are closed, so the contract-conformance and bootstrap-installers subsystems have no open work. The next Eggpack line is whatever the registry lists as `ready`; if that table is empty, the next action is plan authoring, not implementation.
12 changes: 6 additions & 6 deletions architecture/ci-consumer-seam.md
Original file line number Diff line number Diff line change
Expand Up @@ -210,9 +210,9 @@ narrower and still real. The *shape* of the invocation is fixed and finite — o
interpreter, one script path, one candidate path, no shell, no argument vector, no
env map (`consumer_validator.rs:526-534`). The *environment* is built by the
shared runner, which clears it and re-adds a five-variable allowlist
(`crates/eggpack-core/src/builder.rs:735`, `753-754`); the CI side contributes only
(`crates/eggpack-core/src/builder.rs:737`, `755-756`); the CI side contributes only
the caller's explicit `PATH` (`consumer_validator.rs:299-300`), stdin is null
(`builder.rs:736`), and the working directory is explicit
(`builder.rs:738`), and the working directory is explicit
(`consumer_validator.rs:304`). The *outcome is bounded*: timeout, output limits, a
seven-value classification; a validator cannot hang or flood the job. This is a
**separation-of-concerns** mechanism: `Passed` means an independent script exited
Expand Down Expand Up @@ -240,9 +240,9 @@ bounded runner in `eggpack-core`:

Everything the old private runner did is therefore core's contract, not the CI
crate's: process-group/job termination on every failure path, a cleared
environment with a five-variable allowlist (`builder.rs:735`, `753-754`), null
stdin (`builder.rs:736`), the exact output truncation in `drain`
(`builder.rs:942-958`, which keeps `n.min(limit - len)`), and the bounded reader
environment with a five-variable allowlist (`builder.rs:737`, `755-756`), null
stdin (`builder.rs:738`), the exact output truncation in `drain`
(`builder.rs:944-960`, which keeps `n.min(limit - len)`), and the bounded reader
joins. The runner outcome maps onto the consumer-validation outcome exactly
(`consumer_validator.rs:536-555`): success → `Passed`, non-zero exit →
`Failed(NonZeroExit)`, deadline → `Failed(Timeout)`, output bound →
Expand Down Expand Up @@ -442,7 +442,7 @@ Where enforcement is weaker than it looks:
The two gaps that the private CI runner used to have — output retention above the
cap, and a preflight that discarded its over-limit flags — are gone with it. Both
now belong to the shared runner: `drain` truncates exactly
(`crates/eggpack-core/src/builder.rs:942-958`) and the preflight's over-limit
(`crates/eggpack-core/src/builder.rs:944-960`) and the preflight's over-limit
outcome is a non-success runner outcome, which the CI side maps to
`Failed(InterpreterUnavailable)` (`consumer_validator.rs:503-506`).

Expand Down
2 changes: 1 addition & 1 deletion architecture/cli.md
Original file line number Diff line number Diff line change
Expand Up @@ -607,7 +607,7 @@ characters (`411-416`), then delegates to `eggpack_core::run_git_bounded`
peel, `git rev-parse --verify refs/tags/<tag>^{commit}`
(`builder.rs:535-541`); both use the same bounded runner with a 30 s deadline
(`builder.rs:29`), a 4 KiB retained-output cap (`builder.rs:31`), a
`command-group` process group, and a cleared environment (`builder.rs:735`).
`command-group` process group, and a cleared environment (`builder.rs:737`).
See
[process-execution.md](process-execution.md) for the workspace spawn contract.

Expand Down
43 changes: 29 additions & 14 deletions architecture/overview.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,13 @@ It deliberately does **not** replace Eggup: Eggup remains the consumer-side
verified installation/update/rollback layer, and the product repository owns
release/install policy. See [eggup-manifest-consumer-v1.md](eggup-manifest-consumer-v1.md).

Code baseline `fa82486dab83d2369d330a3cef197a3651851c26` — the tree the line
counts and the `file:line` citations in this directory were measured and
verified against. That is the SHA the numbers below describe: this index changes
no Rust source, so the counts and citations stay true of the tree it commits onto.
Re-verify them against the workspace if you edit the overview again.
Code baseline `1cd6d0bf43c93dc9fd572c2d69a3a675a2958b09` — the committed source
immediately before M003pa. The core line counts below were measured and affected
citations checked by symbol against exact implementation candidate
`329a3dfdb166580de4770b2c6b2f046358983003`; hosted run `44118309795` passed all
four lanes. M003pa is closed; its evidence is recorded in
`plans/closure/ci-release-orchestration/003pa-status.md`. Remeasure and recheck
citations against any later source change.
Milestone/evidence statuses are **not** restated here; `plans/registry.md` is the
authority for those, and [principles-roadmap.md](principles-roadmap.md) narrates
them.
Expand Down Expand Up @@ -163,6 +165,18 @@ rewrites in the CLI, manifest, and GitHub source also preserved anchors. Affecte
architecture citations were rechecked by symbol; the line-count table above
remains pinned to `fa82486`.

**2026-11-17 — CI/Release M003pa process-group recheck (closed).** The shared
runner retries after reaping an exited leader and accepts only retry success or
`ESRCH`; a live or unverified group remains a hard failure. Deterministic helper
coverage and the release-marker live-descendant regression passed. The
`run_bounded` anchor is `builder.rs:698`; the timeout regression anchor is
`builder.rs:1835`, both checked by symbol name. The `eggpack-core` source count is
9109 (`builder.rs` 2078, `digest.rs` 325), measured against the implementation
candidate `329a3dfdb166580de4770b2c6b2f046358983003` from baseline
`1cd6d0bf43c93dc9fd572c2d69a3a675a2958b09`. `scripts/check-local.sh` passed, and
hosted run `44118309795` passed Linux stable, Linux 1.89.0, macOS, and Windows on
the exact candidate. Closure evidence: `plans/closure/ci-release-orchestration/003pa-status.md`.

## How to read this document

This file has two jobs, deliberately:
Expand Down Expand Up @@ -241,18 +255,19 @@ contract manifest
|---|---|---|
| `eggpack-contract` | 2937 (2449 + 488 tests) | [contract.md](contract.md) |
| `eggpack-manifest` | 1536 | [manifest.md](manifest.md) |
| `eggpack-core` | 8935 (6 files) | [core.md](core.md) |
| `eggpack-core` | 9109 (6 files) | [core.md](core.md) |
| `eggpack-bootstrap` | 3587 | [bootstrap.md](bootstrap.md) |
| `eggpack-ci` | 12945 (14 files) | [ci.md](ci.md) |
| `eggpack-github` | 5498 (3439 + 2059 tests) | [github.md](github.md) |
| `eggpack-cli` | 8523 (5711 + 2812 tests) | [cli.md](cli.md) |

Counts are Rust source lines per crate, measured against the baseline named
above: every `.rs` file under `crates/<crate>/`, production and test code alike.
A count in parentheses is the split inside the total — `production + tests`. The
test code lives in a `#[cfg(test)]` module in `src/` for every crate except
`contract` (whose conformance and fixture tests are separate `tests/` targets)
and `ci` and `github` (whose test modules are separate out-of-line files).
Counts are Rust source lines per crate, measured on the current worktree
described above: every `.rs` file under `crates/<crate>/`, production and test
code alike. A count in parentheses is the split inside the total — `production +
tests`. The test code lives in a `#[cfg(test)]` module in `src/` for every crate
except `contract` (whose conformance and fixture tests are separate `tests/`
targets) and `ci` and `github` (whose test modules are separate out-of-line
files).

### `eggpack-contract` — layout authority and validators

Expand Down Expand Up @@ -300,10 +315,10 @@ revision verification and for the consumer validator:
| File | Lines | Stage | Deep dive |
|---|---|---|---|
| `src/lib.rs` | 1384 | `PackConfig` → `ReleasePlan`, policy types, `build_manifest` | [core-planning.md](core-planning.md) |
| `src/builder.rs` | 1902 | bindings, command specs, bounded execution, candidate discovery | [core-build.md](core-build.md) |
| `src/builder.rs` | 2078 | bindings, command specs, bounded execution, candidate discovery | [core-build.md](core-build.md) |
| `src/qualification.rs` | 2982 | qualification methods, host matching, evidence | [core-qualification.md](core-qualification.md) |
| `src/finalization.rs` | 928 | `finalize_release`, archive assembly, manifest aggregation | [core-finalization.md](core-finalization.md) |
| `src/digest.rs` | 327 | the one bounded file-digest authority | [core-finalization.md](core-finalization.md) |
| `src/digest.rs` | 325 | the one bounded file-digest authority | [core-finalization.md](core-finalization.md) |
| `src/floor.rs` | 1412 | bounded ELF compatibility-floor inspection | [core-qualification.md](core-qualification.md) |

Crate-level orientation, dependency direction, and the cross-file data
Expand Down
Loading
Loading