Skip to content

security: close 2026-11-16 audit corrective program - #8

Merged
dbowm91 merged 2 commits into
mainfrom
feat/auto-20261116-652bb64d
Nov 17, 2026
Merged

dbowm91 merged 2 commits into
mainfrom
feat/auto-20261116-652bb64d

Conversation

@dbowm91

@dbowm91 dbowm91 commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

Summary

Implements and closes the six security-corrective plans registered in plans/subsystems/security-hardening-roadmap.md (S1–S6 from the 2026-11-16 audit). Restores existing security invariants; adds no proxy capability and changes no pproxy compatibility tier. No version bump, tag, or publication.

  • S1 / Transports 004 — default graph moved to rustls 0.23.46, rustls-webpki 0.103.17, webpki-roots 1.0.12, rustls-platform-verifier 0.7.1, quinn 0.11.12/0.11.19/0.5.16, tokio 1.54.1; bundled-root wording corrected; one redacted warning per ?insecure hop; TLS private-key Debug redacted.
  • S2 / Transports 005 — russh 0.65.2 migration preserving known-hosts policy (certificate host keys rejected); crypto-bigint/ctutils fixed.
  • S3 / Protocols Edge 003 — SOCKS4 compares the full pproxy user:pass user-ID constant-time and never seeds the reuse cache on a username-only match; allow_private_egress = false enforced post-DNS on all three locally resolving UDP paths; CGNAT/NAT64/6to4/Teredo/ORCHID classification; auth-without-TLS warning.
  • S4 / Routing 003 — IPv4-mapped IPv6 canonicalized before CIDR matching; literal-only CIDR warning and docs; admin Host/Origin/JSON Content-Type validation with [admin] allowed_hosts; non-loopback plaintext-admin warning.
  • S5 / Delivery 004 — update-fixtures gating for EGRESS_UPDATE_BASE_URL/file://; in-process SHA-256; trusted absolute curl; private create_new staging with pre-extraction re-hash; system-proxy inspect --json redaction; cargo deny --workspace check in CI and release preflight with four narrow, commented zip ignores.
  • S6 / Parity Compat 003 — --auth documented as the source-IP reuse interval (credentials come from the URI fragment); one startup reuse warning; UDP error, translate --annotate, and reverse IR Debug redaction; manifest claim unchanged.

Verification

  • cargo fmt --all -- --check — pass
  • cargo clippy --workspace --all-targets -- -D warnings — pass
  • cargo test --workspace --locked — 3,097 passed, 0 failed (151 pre-existing ignored), 138 binaries
  • CLI slice full,ssh,quic,pproxy-legacy,legacy-crypto,pproxy-daemon; embed ssh, pproxy-compat, ssh,pproxy-compat — pass
  • Embed OpenSSH regression — 6/6
  • cargo deny --workspace check — advisories/bans/licenses/sources ok
  • cargo audit --ignore RUSTSEC-2023-0071 — only the four tracked zip 6.0.0 advisories

Tracked residuals

  • zip 6.0.0 (RUSTSEC-2026-0429/-0367/-0368/-0369): upstream eggup-archive pins zip = "6.0.0". Narrow, commented deny.toml exception with owner and review date 2027-05-01; remove when upstream ships zip >= 9.0.0.
  • pproxy check --json still emits raw_args and chain_info[].raw because the capability manifest describes them as raw. Recorded as the parity milestone's medium residual; needs a coordinated manifest/Python/CLI change.
  • UdpTargetFlow::new gained a required policy parameter (supporting public crate surface); account for it in the next release's semver/changelog decision.
  • Admin TLS remains unimplemented by design; non-loopback admin is warned about, not encrypted.
  • Oracle/differential/interop suites were not run because no compatibility claim changed.

Closure records: plans/closure/{transports/004,transports/005,protocols-edge/003,routing-health-observability/003,delivery/004,parity-compat/003}-status.md.

CI Test added 2 commits November 17, 2026 13:03
Implement and verify S1-S6 from
plans/subsystems/security-hardening-roadmap.md:

- S1: rustls 0.23.46, rustls-webpki 0.103.17, webpki-roots 1.0.12,
  rustls-platform-verifier 0.7.1, quinn 0.11.12/0.11.19/0.5.16, tokio 1.54.1;
  bundled-root wording corrected; insecure-hop warning; TLS private-key Debug
  redaction.
- S2: russh 0.65.2 migration preserving known-hosts policy; certificate
  host keys rejected; crypto-bigint/ctutils moved to fixed versions.
- S3: SOCKS4 full user:pass enforcement and no cache seeding on failure; UDP
  private-egress policy applied after DNS on all locally resolving paths;
  CGNAT/NAT64/6to4/Teredo/ORCHID classification; auth-without-TLS warning.
- S4: IPv4-mapped IPv6 canonicalization for CIDR matching; literal-only CIDR
  warning and docs; admin Host/Origin/JSON Content-Type validation with
  allowed_hosts; non-loopback plaintext admin warning.
- S5: updater fixture gating, in-process SHA-256, trusted absolute curl,
  private create-new staging with pre-extraction re-hash, system-proxy JSON
  redaction, and cargo deny --workspace check in CI/release preflight with a
  narrow tracked zip exception.
- S6: pproxy auth-reuse documentation and startup warning; compat UDP error,
  translate --annotate, and reverse IR Debug redaction; manifest claim
  unchanged.

Verification: cargo fmt --all --check; workspace clippy -D warnings; workspace
tests 3097 passed / 0 failed; CLI and embed feature slices; embed OpenSSH 6/6;
cargo deny --workspace check; cargo audit reports only the four tracked
zip 6.0.0 advisories. No version bump, tag, or publication.
The advisory database published RUSTSEC-2026-0545/-0547/-0548 (zip 6.0.0)
and RUSTSEC-2026-0543 (chrono unmaintained via russh-util) after the
security-corrective closure. All are unreachable-by-feature or
unmaintained-only and remain blocked upstream:

- zip: eggup-archive pins 6.0.0; Eggress verifies the archive SHA-256,
  uses no extract()/ZipStreamReader API, and Eggup disables aes-crypto.
- chrono: unconditional russh-util dependency in the latest russh 0.65.2;
  reachable only through the optional ssh feature.

Add narrow, commented ignores with owners and 2027-05-01 review dates and
record the changed residual set in the closure records, registry, roadmap,
and CI/release docs.
@dbowm91
dbowm91 merged commit 5b3d268 into main Nov 17, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant