Repository navigation
security: close 2026-11-16 audit corrective program - #8
Merged
Merged
Conversation
added 2 commits
November 17, 2026 13:03
Implement and verify S1-S6 from plans/subsystems/security-hardening-roadmap.md: - S1: rustls 0.23.46, rustls-webpki 0.103.17, webpki-roots 1.0.12, rustls-platform-verifier 0.7.1, quinn 0.11.12/0.11.19/0.5.16, tokio 1.54.1; bundled-root wording corrected; insecure-hop warning; TLS private-key Debug redaction. - S2: russh 0.65.2 migration preserving known-hosts policy; certificate host keys rejected; crypto-bigint/ctutils moved to fixed versions. - S3: SOCKS4 full user:pass enforcement and no cache seeding on failure; UDP private-egress policy applied after DNS on all locally resolving paths; CGNAT/NAT64/6to4/Teredo/ORCHID classification; auth-without-TLS warning. - S4: IPv4-mapped IPv6 canonicalization for CIDR matching; literal-only CIDR warning and docs; admin Host/Origin/JSON Content-Type validation with allowed_hosts; non-loopback plaintext admin warning. - S5: updater fixture gating, in-process SHA-256, trusted absolute curl, private create-new staging with pre-extraction re-hash, system-proxy JSON redaction, and cargo deny --workspace check in CI/release preflight with a narrow tracked zip exception. - S6: pproxy auth-reuse documentation and startup warning; compat UDP error, translate --annotate, and reverse IR Debug redaction; manifest claim unchanged. Verification: cargo fmt --all --check; workspace clippy -D warnings; workspace tests 3097 passed / 0 failed; CLI and embed feature slices; embed OpenSSH 6/6; cargo deny --workspace check; cargo audit reports only the four tracked zip 6.0.0 advisories. No version bump, tag, or publication.
The advisory database published RUSTSEC-2026-0545/-0547/-0548 (zip 6.0.0) and RUSTSEC-2026-0543 (chrono unmaintained via russh-util) after the security-corrective closure. All are unreachable-by-feature or unmaintained-only and remain blocked upstream: - zip: eggup-archive pins 6.0.0; Eggress verifies the archive SHA-256, uses no extract()/ZipStreamReader API, and Eggup disables aes-crypto. - chrono: unconditional russh-util dependency in the latest russh 0.65.2; reachable only through the optional ssh feature. Add narrow, commented ignores with owners and 2027-05-01 review dates and record the changed residual set in the closure records, registry, roadmap, and CI/release docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements and closes the six security-corrective plans registered in
plans/subsystems/security-hardening-roadmap.md(S1–S6 from the 2026-11-16 audit). Restores existing security invariants; adds no proxy capability and changes no pproxy compatibility tier. No version bump, tag, or publication.rustls 0.23.46,rustls-webpki 0.103.17,webpki-roots 1.0.12,rustls-platform-verifier 0.7.1,quinn 0.11.12/0.11.19/0.5.16,tokio 1.54.1; bundled-root wording corrected; one redacted warning per?insecurehop; TLS private-keyDebugredacted.russh 0.65.2migration preserving known-hosts policy (certificate host keys rejected);crypto-bigint/ctutilsfixed.user:passuser-ID constant-time and never seeds the reuse cache on a username-only match;allow_private_egress = falseenforced post-DNS on all three locally resolving UDP paths; CGNAT/NAT64/6to4/Teredo/ORCHID classification; auth-without-TLS warning.Host/Origin/JSONContent-Typevalidation with[admin] allowed_hosts; non-loopback plaintext-admin warning.update-fixturesgating forEGRESS_UPDATE_BASE_URL/file://; in-process SHA-256; trusted absolutecurl; privatecreate_newstaging with pre-extraction re-hash;system-proxy inspect --jsonredaction;cargo deny --workspace checkin CI and release preflight with four narrow, commentedzipignores.--authdocumented as the source-IP reuse interval (credentials come from the URI fragment); one startup reuse warning; UDP error,translate --annotate, and reverse IRDebugredaction; manifest claim unchanged.Verification
cargo fmt --all -- --check— passcargo clippy --workspace --all-targets -- -D warnings— passcargo test --workspace --locked— 3,097 passed, 0 failed (151 pre-existing ignored), 138 binariesfull,ssh,quic,pproxy-legacy,legacy-crypto,pproxy-daemon; embedssh,pproxy-compat,ssh,pproxy-compat— passcargo deny --workspace check— advisories/bans/licenses/sources okcargo audit --ignore RUSTSEC-2023-0071— only the four trackedzip 6.0.0advisoriesTracked residuals
zip 6.0.0(RUSTSEC-2026-0429/-0367/-0368/-0369): upstreameggup-archivepinszip = "6.0.0". Narrow, commenteddeny.tomlexception with owner and review date 2027-05-01; remove when upstream shipszip >= 9.0.0.pproxy check --jsonstill emitsraw_argsandchain_info[].rawbecause the capability manifest describes them as raw. Recorded as the parity milestone's medium residual; needs a coordinated manifest/Python/CLI change.UdpTargetFlow::newgained a required policy parameter (supporting public crate surface); account for it in the next release's semver/changelog decision.Closure records:
plans/closure/{transports/004,transports/005,protocols-edge/003,routing-health-observability/003,delivery/004,parity-compat/003}-status.md.