Repository navigation
plans: Python native M005 cancellation/config corrective and M006 M004 closure - #7
Merged
Merged
Conversation
M005 corrective: barrier-controlled Rust drop evidence at SDK and bridge layers, concurrent close taxonomy, 32-call saturation recovery, and Rust-owned from_default_config preserving no-arg defaults.
Closure evidence at plans/closure/python-native-library/005-status.md for candidate baf00cf; roadmap and registry move M005 to closed and M006 to ready. M004 stays active pending post-M005 exact-SHA qualification.
On hosts where dirs::config_dir() is unavailable, default_config_path() falls back to relative eggsearch.toml, so the platform-config tests shared one working-directory file and Windows smoke failed. Run each test under its own tmp_path CWD and accept the documented fallback filename. No production change.
The non-unix safe_open_relative branch probed the jail root with File::open, which fails on directories under Windows, voiding every jail-checked content read (local snippets, security-search reads). Check directory-ness via metadata instead, preserving the error taxonomy and unix symlink parity. Adds a file-as-root regression test; the existing roundtrip tests already cover the Windows failure mode. Python config tests revert temporary diagnostics, keeping the CWD-isolation repair.
Closure evidence at plans/closure/python-native-library/004-status.md, 006-status.md and 007-status.md for candidate faa1da2, qualifying run 38617598636 (5/5 builds, 20/20 smokes, offline sdist rebuild). Roadmap and registry move M004, M006 and M007 to closed. No publication; code bytes identical to faa1da2.
…g (M008) Cargo.lock rustls 0.23.45 -> 0.23.46 resolves RUSTSEC-2026-0346/0347/ 0348/0349 with no manifest change; cargo deny check fully green. safe_open non-unix walk now rejects walk-time symlinks via symlink_metadata (SymlinkDetected parity with unix) instead of silently following them; regression tests for final and intermediate links plus a Windows-only smoke test. Check-to-open race remains explicitly contained (no atomic no-follow open in std).
The qualification audit checks the binding crate graph (bindings/python), which pins its own rustls copy. Same patch bump as the root lockfile; no manifest change.
Linux CI rejects the intermediate link with a non-SymlinkDetected variant from the untouched unix branch; the guard that matters is fail-closed. Windows stays pinned to SymlinkDetected. A forensic size report fires if unix ever opens through the link.
Closure evidence at plans/closure/python-native-library/008-status.md for candidate 067468a, qualifying run 38641009246 (27/27 including audit). Roadmap and registry move M008 to closed with M001-M008 complete; architecture TOCTOU claims corrected to ground truth. No publication; code and lockfile bytes identical to 067468a.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Provide bounded handoff plans to finish the native Python library workstream after M001–M003 closed and M004's baseline qualification succeeded. This is planning only, not a claim of implemented fixes or release publication.
New plans
plans/implementation/python-native-library/005-inflight-cancellation-and-default-config-corrective.md— ready. Corrective to M002/M003 coverage: barrier-controlled cancellation after actual Rust work starts; concurrentaclose()and semaphore/drain evidence; preserve existingAsyncEggsearch()defaults while introducing a discoverable opt-in to the CLI's platform default config path, including deterministic regressions and type/docs updates.plans/implementation/python-native-library/006-m004-exact-sha-distribution-closure.md— blocked by M005 closure. Requalify wheels and extracted sdist on post-corrective exact SHA; record hashes, 5-platform x 4-Python version smoke, root gates and persistent closure evidence. Prepare004-status.mdand006-status.mdtogether with registry/roadmap closure; no publication.Baseline evidence
main1434c1e55ddd92947042cff9918ffc0fe130ed01: Python qualification run 38522548258 completed 27 jobs successfully (5 builds, 20 wheel smokes, sdist and audit), alongside green root CI, drift and egress qualification. There is no M004 closure record and the candidate will change if M005 modifies code. Requalification is mandatory.Governance and scope
Updated
plans/subsystems/python-native-library-roadmap.mdandplans/registry.mdwith correct dependency and status gates. Historical closure records M001–M003 remain untouched. Preserve ten MCP operations, Mode-Off no-remote-dispatch, Rust 1.89, trust/SSRF limits, and Eggpack binary assets. PyPI publication requires separate explicit authorization.Verification
Git compare verifies only four planning files changed: two new plans, roadmap and registry. No runtime code was edited, so there are no newly claimed test runs on this planning branch.