Skip to content

Complete security-assurance workstream - #69

Open
dbowm91 wants to merge 2 commits into
mainfrom
chore/prune-comments-and-plans
Open

dbowm91 wants to merge 2 commits into
mainfrom
chore/prune-comments-and-plans

Conversation

@dbowm91

@dbowm91 dbowm91 commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

Description

Implements the security-assurance workstream through M005:

  • M001: add narrowly scoped, review-dated advisory exceptions, the required license, mirrored audit configuration, and a self-testing advisory check.
  • M002: add the dedicated advisory CI gate and pin mutable GitHub Actions references.
  • M003: reconcile security documentation with implementation and add architecture guards against retracted claims.
  • M004: add global registration and metrics-auth budgets, tighten Unix server-data permissions, and bump snip-sync to 0.2.0.
  • M005: add payload-v2 read support with snippet-ID-bound AAD while retaining v1 compatibility.
  • M006 remains deliberately blocked: the v2 write switch must wait for a published v2-reading snp release and a stated minimum supported client version.

Planning records, accepted ADRs, and closure records are included. No protocol or snip-proto changes; no commits or releases beyond this PR branch.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Documentation update
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (no functional changes)

Testing

  • cargo fmt --all -- --check passes
  • cargo clippy --all-targets -- -D warnings passes
  • cargo test passes
  • Manual testing performed (describe below)

Local checks run and passed:

  • cargo check --workspace --all-targets
  • cargo test --workspace --lib with isolated XDG_CONFIG_HOME
  • Focused integration targets: architecture, sync integration/multibatch/contracts, snip-sync lifetime, public API, platform smoke, destination permissions, auto-sync closure/concurrency, restore manifest, selector/search parity, and CLI surface compatibility
  • cargo audit, cargo deny check, bash scripts/check-advisories.sh, and its --self-test
  • bash scripts/ci/test-production-seams.sh (5/5)

On macOS, the full scripts/check.sh is blocked by the existing installer test setting PATH without /bin; the constituent relevant test targets were run individually. The local clippy run needed allowances for two pre-existing macOS-only findings; Linux CI will run the repository's normal gate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant