Repository navigation
Conversation
…w touch and pen Playback committed React state ten times a second, and each commit rendered the whole viewer: under a 4x CPU throttle a frame cost 12 ms of main thread for one 512 px panel and 18.7 ms for three, over a 60 Hz budget on a slower laptop or a phone. Stats, histogram and star state now commit once a second while playing; the slider, counters and each panel's frame label are written to the page every frame. Measured: 4.1 ms and 5.3 ms per frame, WebGPU on the Apple adapter. The resize grips of Show3D, Show2D and Show3DSlices' volume, and Show3D's profile height, listened to mouse events only, which a finger drag never sends. They use pointer events with capture, and on touch screens the 16 px grip takes a 44 px hit area. A touch drag at Galaxy Fold cover size now resizes the panel.
…e ROI and moves the Lens; wider fps slider and larger slider thumbs on touch screens
…Slices axis panels; Show4DSTEM profile bars too; browser test drags every viewer's grip by touch; ROI hint says drag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does it solve?
Turning images into a page people can share or embed needed Python. This adds
quantem-widget show2d/show3d(one lossless HTML page from files, a stack or a folder) and an agent recipe for it. It also adds a Show3D frame thumbnail strip for watching a recording (mode="stream"), Show2D color export, and true color on WebGPU in Show3D and Show2D.Four commits:
feat: CLI, thumbnail strip, color export, Export fixesquantem-widget(wasquantem; no alias).show2dandshow3dtake--save-dir,--encoding,--image-bin,--max-mband--no-link-contrast.thumbnails=,thumbnail_columns=1|2|3, ormode="stream", whichShow3D.stream()opens in.encoding="full").fix: quantem.gpu pin2786134a; the ShowPtycho launch-table tests expect theValueandSourcecolumns.display: true color on WebGPU. Show3D and Show2D draw true-color frames on WebGPU (they drew on the CPU canvas). Rebased onto the new canvas pooling incolormapEngine.ts: the RGB path now hands its canvas back throughtransferOffscreen.test:QUANTEM_WIDGET_WINDOW_POSITIONplaces the headed browser-test window.What should reviewer(s) do?
js/show3d/index.tsxandjs/display/colormapEngine.tsstill match the WebGPU interactivity commits on main (41f71231..7d084aea). This branch was rebased onto them; onlycolormapEngine.tsandCHANGELOG.mdconflicted, and both were resolved by keeping both sides.mode="stream",thumbnails,thumbnail_columns,--save-dir.Verification
gpu-ref.txt); the ShowPtycho, CLI, Show2D, Show3D and infrastructure tests were re-run after the last rebase.npx vitest run392 passed;npx tsc --noEmitclean; the bundle builds against quantem.gpu2786134a.file://and inside an<iframe>;QUANTEM_WIDGET_BROWSER=1). It was stopped partway on the previous base when main moved.