FuzzySearch: remaining cleanup from #1788 - #1802
Draft
jeremypw wants to merge 2 commits into
Draft
Conversation
Collaborator
Author
|
@danirabbit I was just going to merge master into #1788 but it proved complicated so I made this PR instead.to see what else needed doing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The remaining cleanups seem to be mainly reordering, reformatting and losing some unnecessary members. I have removed some additional unused/unnecessary members.
It is noted that the placeholder text in the entry is never shown since the entry is always in focus so the initial view appears rather empty. Maybe consider adding a place holder in the scrolled window, which after this PR remains in view even when empty.