Sort escaped map/struct fields for deterministic compile output - #4785
Merged
josevalim merged 1 commit intoAug 21, 2026
Merged
Conversation
Several builder escape functions re-embed a compile-time-computed map/struct as a literal AST via bare Map.to_list/1. Map.to_list/1's field order isn't guaranteed stable across separate compiler invocations for a map that went through updates (as opposed to a fresh literal), so two builds of identical source can produce different compiled bytecode whenever any of these get folded into a literal at compile time (e.g. any from/2 call with a compile-time-known clause like limit: 1, or a select with multiple map(binding, fields) terms).
Member
|
💚 💙 💜 💛 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several builder escape functions re-embed a compile-time-computed map/struct as a literal AST via bare
Map.to_list/1.Map.to_list/1's field order isn't guaranteed stable across separate compiler invocations, so two builds of identical source can produce different compiled bytecode whenever any of these get folded into a literal at compile time.