Repository navigation
Build against embabel-agent 2.0 capability traits - #58
Draft
jasperblues wants to merge 2 commits into
Draft
jasperblues wants to merge 2 commits into
jasperblues wants to merge 2 commits into
Conversation
3 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shows what the embabel-agent 2.0 capability-traits stack (embabel/embabel-agent#2185) changes for Guide. Nothing has to change. One optional cleanup is included.
Do not merge. The PR builds against
1.5.4-capability-traits-SNAPSHOT, a local install of the stack, so CI cannot resolve it. When 2.0 is released, change the version to 2.0 and merge.Commit 1: version bump only. Guide compiles, and all 183 tests pass, with no code changes. Guide calls models through
Ai,PromptRunnerandwithLlmService, and the stack leaves those unchanged.Commit 2 (optional): chat models through the named platforms.
UserModelFactorybuilt each provider's chat model itself, with Mistral's and DeepSeek's base URLs written into Guide.OpenAiPlatform,AnthropicPlatform,MistralAiPlatformorDeepSeekPlatform. The endpoints live in embabel-agent.Guide's cache and key validation are unchanged. All 183 tests pass, including
UserModelFactoryTest, which builds a model for each provider.A live check with an OpenAI key also passed:
validateKeyaccepted the key, and the chat model built throughOpenAiPlatformanswered a prompt. The check is not committed.