Skip to content

README: Postgres tests need Docker #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasperblues merged 1 commit into from
Oct 23, 2026
Merged

README: Postgres tests need Docker #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,7 +644,7 @@ Tests require the following:
export OPENAI_API_KEY=sk-your-key-here
```

2. **Neo4j**: See the [Local vs CI Testing](#local-vs-ci-testing) section below.
2. **Neo4j**, and **Docker** for the Postgres tests: See the [Local vs CI Testing](#local-vs-ci-testing) section below.

3. **A JDK between 21 and 25**. The build targets Java 21 bytecode, so the resulting jar
runs on any JRE 21+, but it builds on anything up to 25 — CI runs the suite on both 21
Expand Down Expand Up @@ -687,6 +687,11 @@ export USE_LOCAL_NEO4J=true

Leave `USE_LOCAL_NEO4J` unset (the default). GitHub Actions uses Testcontainers to automatically spin up Neo4j.

#### Postgres tests

The `*PostgresTest` classes rerun the store tests on Postgres. They start Postgres with pgvector in a Testcontainer
whatever `USE_LOCAL_NEO4J` says, so `./mvnw test` needs Docker even with a local Neo4j.

### Running Tests

```bash
Expand Down
2 changes: 1 addition & 1 deletion src/main/kotlin/com/embabel/guide/stats/GuideStatsService.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import java.time.Instant
* reuses [GuideUserCache]; its TTL is what makes an out-of-band grant/revocation take effect.
*
* Totals use single-label fragment counts. The rankings are Drivine grouped reads: one statement
* each, on every store Drivine supports, Oracle among them.
* each, on every store Drivine supports, Oracle and Postgres among them.
*/
@Service
class GuideStatsService(
Expand Down
Loading