Repository navigation
Conversation
…026-11-04 # Conflicts: # README.md
…026-11-04 # Conflicts: # samples/HOLO_Holo.shader
…026-11-04 # Conflicts: # libs/metadata.py # src/UnityShaderDecompiler.Cli/Program.cs # src/UnityShaderDecompiler.Core/Core/Hlsl/HlslPrettyPrinter.cs # src/UnityShaderDecompiler.Core/Decompiler.cs
…2026-11-04 # Conflicts: # src/UnityShaderDecompiler.Core/Core/Hlsl/HlslPrettyPrinter.cs
…2026-11-04 # Conflicts: # README.md # samples/HOLO_Holo.shader
…2026-11-04 # Conflicts: # README.md
…2026-11-04 # Conflicts: # README.md # src/UnityShaderDecompiler.Core/Core/Hlsl/HlslPrettyPrinter.cs
…to test/pr-integration-2026-11-04
end3rbyte
changed the title
Preserve named constants and require verified resource identities instead of raw replacement arrays or property-order bindings. Nine focused tests pass on this branch; the combined checkout passes 16 focused tests but retains 28 full-suite failures. Complete parameter extraction and Unity rendering validation remain required.
Keep parameter records out of code parsing and reject malformed referenced records in restored-variant mode. Remove property-order texture binding overrides. Three reader tests pass independently; all 16 focused tests pass with the other correction branches integrated. Native reflection checks do not establish Unity rendering equivalence.
Check pass counts, manifest hashes and keyword-to-program mappings against original serialized references, then recompile every restored variant. Four oracle guards pass. All three real shader cases currently fail strict conversion on missing resource metadata; extraction-only success is no longer sufficient. Unity rendering validation remains blocked.
…into test/pr-integration-2026-11-04
…t/pr-integration-2026-11-04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
not to be merged