Repository navigation
v0.7.1: fix #44, #45, #47 - #48
Merged
Merged
Conversation
Another view of the same session (a GOA tab, the Canvas page's agent panel) can resize the session; the terminal asks for its size only when its own changes, so going back to the first view left the session at the other's size, drawn in a corner, until the window was resized (#44). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A task GOA set back to working, or whose turn's end went unheard on an agent without hooks, stayed open on an idle session: every next task was queued behind it and never went in (#45). An idle session past the idle limit now has that one task marked turn-ended, GOA told, and the new task goes in. A queue names the task holding it and how to settle it, and goa task takes only done, failed and stopped. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Its token records were read every 20 seconds with a LIKE over every part, in one statement, whether or not OpenCode ran; OpenCode reported its own writes timing out on a locked database (#47). Parts are now read after the last one by update time and id, 200 at a time, with a one-second lock wait, and only while one of its sessions runs and once just after. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thanks for addressing these so quickly! The approach for paged token reading, stale-task handling for hookless agents like OpenCode, and viewport resize looks spot on. A few notes and suggestions from the Windows 11 & OpenCode side:
Appreciate the great work and looking forward to v0.7.1! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Three fixes from @sicknewbie's reports, and the version set to 0.7.1.
Fixes #44
Fixes #45
Fixes #47
ui/settledresize.go).goa tasktakes only done, failed or stopped (daemon/goa_stale.go,cli/goa.go).LIKE '%step-finish%'over every part, every 20 seconds, OpenCode running or not. It now reads 200 parts at a time by update time and id, read-only with a one-second lock wait, only while an OpenCode-family session runs and once just after (core/tokens/adapt_opencode.go,daemon/tokens_live.go).This changes
version/, so merging deploys enowX Cloud. It has no migration.How it was tested
New tests:
TestViewBackInSightAsksItsSizeAgain,TestGOADeliversToAnIdleWorkerWithAStaleTask,TestGOAQueuesForABusySessionNamingWhatHoldsIt,TestGOATaskTakesOnlySettlingStatuses,TestOpenCodeReadInPagesCountsTheSame(same counts paged as read whole),TestOpenCodeRecordsReadOnlyWhileItRuns.Locally on Linux:
go build ./...,go vetand the tests of the changed packages (core/tokens,cli, and selections ofdaemonandui).Not verified on Windows, where all three were reported, nor with a real OpenCode 1.18.
Docs updated where behavior changed (
docs/goa.md,docs/cli.md,docs/tokens.md)🤖 Generated with Claude Code