Repository navigation
The web deadlock graph's process pane wraps its SQL handle note and property lines (#6224) - #6228
Merged
Merged
Conversation
…very property line (#6224)
erikdarlingdata
marked this pull request as ready for review
October 20, 2026 15:16
erikdarlingdata
enabled auto-merge (squash)
October 20, 2026 15:16
This was referenced Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude posting for Erik Darling.
Closes #6224.
Why
In the web dashboard's deadlock graph, the process detail pane's SQL handle note ("A handle covers a whole batch or procedure: ...") and every property line ran out past the pane's right edge on one line. The graph is drawn inside a data table cell, and a data cell is
white-space: nowrap. The pane inherited that. Only thepre.codeblocks (handle lines, SQL text) setpre-wrapthemselves, so they were fine; the.dlg-propdivs and the heading were not. Measured in the browser before the change: every pane child computedwhite-space: nowrap, the note was a single 17 px line, and 5 elements overflowed the pane (6 at 390 px).What changes
Darling/PerformanceMonitor.Darling.Service/wwwroot/css/app.css:.dlg-sidenow setswhite-space: normal; overflow-wrap: anywhere, so the note, the property lines and the heading wrap, and a long hex handle can break anywhere. Thepre.codeblocks keeppre-wrap.PerformanceMonitor.Ui/DeadlockGraphControl.xaml.cs("SQL Handles" block): checked, no change needed. The hint is aTextBlockwithTextWrapping.Wrap, the handle list is aTextBoxwithTextWrapping.Wrap, and the propertiesScrollViewerhas horizontal scrolling disabled, so the text wraps inside the 340 px panel. Lite and Darling share this control.Test plan
pre-push.shfrom PowerShell 7 (guard stage 4446 and 1196 tests green; selected classes 3270 Darling and 296 Lite, 0 failed).Last line of
pre-push.sh:GATE GREEN: guard stage of both suites and 188+29 selected classes in 2 batches passed (logs /tmp/pre-push.vZEvXv)Proposed CHANGELOG line
SECTION: Fixed