Repository navigation
PostgreSQL Query Shapes statement grid no longer looks blank, and the OS CPU grid shows rounded numbers (#6225) - #6229
Merged
Conversation
…as many lines, and the OS CPU, captured-plan, lock and buffer grids show rounded numbers (#6225)
erikdarlingdata
marked this pull request as ready for review
October 20, 2026 15:19
erikdarlingdata
enabled auto-merge (squash)
October 20, 2026 15:19
This was referenced Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude posting for Erik Darling.
Closes #6225.
Why
130.67499999999) and the disk columns printed bare byte counts.What changes
FreeTextCellstyle (Themes/DarkTheme.xaml) caps a text cell at 90 px, the same cap the SQL Server grids put on query text. It is applied to the free-text cells of the PostgreSQL Activity tab: Statement, the blocking chain's Root and Victim statements, the captured plan JSON, and the deadlock and log-event grids' Lock Modes, Resources, Victim Statement, Message, Detail and Context.PgDisplay.KernelStatrow. The ms columns are rounded to one place like the tab's other ms columns, the disk columns read as sizes (0 B,3.0 MB), and they sort by the byte count. The headers lose "(bytes)" because the unit is now in the value.PgDisplay.CapturedPlanrow; Total, Max and Avg (ms) are rounded to one place (they were raw doubles too).Test plan
ViewerPostgresQueryShapesGridRenderTests(5 tests) build the real PostgreSQL server tab, open Activity and the sub-tab, and read the text each cell shows. With the cap removed from the XAML, the statement-grid and log-event-grid tests fail ("the first row is 4849 px tall in a 234 px grid and its Calls value sits at 2462 px", and the same for the log grid's PID at 4849 px / 220 px); with it they pass. The OS CPU and captured-plans tests check the rounded and sized cell text; they exercise the new mapper rows, so they could not be run against the old code (the mapper did not exist; the old binding was the raw record, which is what the issue shows).ViewerGridTimeColumnSortMemberTests,XamlGridRowRangeTests,ViewerClippedText*, every Census and Ratchet class and the Guard trait: 505 tests, 0 failed..github/scripts/pre-push.shfrompwsh: both Guard stages green (darling 4446, lite 1196, 0 failed). The selection is the whole suite, so the gate stops there and CI decides the rest.Last line of
pre-push.sh:GATE STOP: selection is the whole suite (darling 2050, lite 577): run the brief's classes; CI decides (over PRE_PUSH_MAX_CLASSES=400 in one project; no selected class ran; logs /tmp/pre-push.CQw7GI)Proposed CHANGELOG line
SECTION: Fixed
ENTRY: